https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=perf-tmp 2025-07-18T01:13:21+00:00 2025-07-18T01:13:21+00:00 León Orell Valerian Liehr me@fmease.dev 2025-06-18T20:10:53+00:00 urn:sha1:1df99f22d3a1776b36fc00fc35626fd841f7242f 2025-06-16T23:27:58+00:00 Jieyou Xu jieyouxu@outlook.com 2025-06-16T09:53:44+00:00 urn:sha1:2dd9cc113067113453efcff722e3a5c0893a6244 2025-03-23T14:11:04+00:00 Michael Goulet michael@errs.io 2025-03-06T20:50:51+00:00 urn:sha1:eb3707e4b49e7d19d048cf2187d6e3643be9dba2 2025-03-01T15:03:18+00:00 Matthias Krüger matthias.krueger@famsik.de 2025-03-01T15:03:18+00:00 urn:sha1:a500a43367b862e35942ed85f376656140faad06 Tweak invalid RTN errors Make suggestions verbose. When encountering `method(type)` bound, suggest `method(..)` instead of `method()`. ``` error: argument types not allowed with return type notation --> $DIR/bad-inputs-and-output.rs:9:23 | LL | fn foo<T: Trait<method(i32): Send>>() {} | ^^^^^ | help: remove the input types | LL - fn foo<T: Trait<method(i32): Send>>() {} LL + fn foo<T: Trait<method(..): Send>>() {} | ``` When encountering both return type and arg list that isn't `..`, suggest replacing both. ``` error: return type not allowed with return type notation --> $DIR/bad-inputs-and-output.rs:12:25 | LL | fn bar<T: Trait<method() -> (): Send>>() {} | ^^^^^^ | help: use the right argument notation and remove the return type | LL - fn bar<T: Trait<method() -> (): Send>>() {} LL + fn bar<T: Trait<method(..): Send>>() {} | ``` When encountering a return type, suggest removing it including the leading whitespace. ``` error: return type not allowed with return type notation --> $DIR/bad-inputs-and-output.rs:24:45 | LL | fn bay_path<T: Trait>() where T::method(..) -> (): Send {} | ^^^^^ | help: remove the return type | LL - fn bay_path<T: Trait>() where T::method(..) -> (): Send {} LL + fn bay_path<T: Trait>() where T::method(..): Send {} | ``` r? ``@compiler-errors`` 2025-02-28T21:18:53+00:00 Esteban Küber esteban@kuber.com.ar 2025-02-28T20:05:43+00:00 urn:sha1:adb5ecabdb09ff6f329bbf9b7721036db983f546 Make suggestions verbose. When encountering `method(type)` bound, suggest `method(..)` instead of `method()`. ``` error: argument types not allowed with return type notation --> $DIR/bad-inputs-and-output.rs:9:23 | LL | fn foo<T: Trait<method(i32): Send>>() {} | ^^^^^ | help: remove the input types | LL - fn foo<T: Trait<method(i32): Send>>() {} LL + fn foo<T: Trait<method(..): Send>>() {} | ``` When encountering both return type and arg list that isn't `..`, suggest replacing both. ``` error: return type not allowed with return type notation --> $DIR/bad-inputs-and-output.rs:12:25 | LL | fn bar<T: Trait<method() -> (): Send>>() {} | ^^^^^^ | help: use the right argument notation and remove the return type | LL - fn bar<T: Trait<method() -> (): Send>>() {} LL + fn bar<T: Trait<method(..): Send>>() {} | ``` When encountering a return type, suggest removing it including the leading whitespace. ``` error: return type not allowed with return type notation --> $DIR/bad-inputs-and-output.rs:24:45 | LL | fn bay_path<T: Trait>() where T::method(..) -> (): Send {} | ^^^^^ | help: remove the return type | LL - fn bay_path<T: Trait>() where T::method(..) -> (): Send {} LL + fn bay_path<T: Trait>() where T::method(..): Send {} | ``` 2025-02-28T03:35:13+00:00 Esteban Küber esteban@kuber.com.ar 2025-02-28T03:35:13+00:00 urn:sha1:86945c0a545643457e551a78e8c2a90355d0f17c Provide a better suggestion message, and make the suggestion verbose. ``` error[E0703]: invalid ABI: found `riscv-interrupt` --> $DIR/riscv-discoverability-guidance.rs:17:8 | LL | extern "riscv-interrupt" fn isr() {} | ^^^^^^^^^^^^^^^^^ invalid ABI | = note: invoke `rustc --print=calling-conventions` for a full list of supported calling conventions help: there's a similarly named valid ABI `"riscv-interrupt-m"` | LL | extern "riscv-interrupt-m" fn isr() {} | ++ ``` 2025-02-11T17:04:34+00:00 Matthias Krüger matthias.krueger@famsik.de 2025-02-11T17:04:34+00:00 urn:sha1:65d20f39f3d1706d239abb53ef271b5612ec60e7 show supported register classes in error message a simple diagnostic change that shows the supported register classes when an invalid one is found. This information can be hard to find (especially for unstable targets), and this message now gives at least something to try or search for. I've followed the pattern for invalid clobber ABIs. `@rustbot` label +A-inline-assembly 2025-02-10T04:45:47+00:00 Jubilee Young workingjubilee@gmail.com 2025-02-07T20:18:15+00:00 urn:sha1:cd9d39e3604680db58acbe409590d495e883d053 These are either residue of a long-term migration away from something, or are simply trying too hard to be specifically useful: nearest-match suggestions for ABI strings should handle this. 2025-01-29T11:15:12+00:00 Folkert de Vries folkert@folkertdev.nl 2025-01-29T10:57:37+00:00 urn:sha1:fbd30ea35fb79d73faa9d5b3feae391fed5336c8 in inline assembly, show the supported register classes when an invalid one is found 2024-12-18T02:38:53+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-12-12T23:29:23+00:00 urn:sha1:2620eb42d72d24baa1ca1056a769862b92c85f7f `rustc_span::symbol` defines some things that are re-exported from `rustc_span`, such as `Symbol` and `sym`. But it doesn't re-export some closely related things such as `Ident` and `kw`. So you can do `use rustc_span::{Symbol, sym}` but you have to do `use rustc_span::symbol::{Ident, kw}`, which is inconsistent for no good reason. This commit re-exports `Ident`, `kw`, and `MacroRulesNormalizedIdent`, and changes many `rustc_span::symbol::` qualifiers in `compiler/` to `rustc_span::`. This is a 200+ net line of code reduction, mostly because many files with two `use rustc_span` items can be reduced to one.