https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.84.0 2024-10-25T18:31:40+00:00 2024-10-25T18:31:40+00:00 Ralf Jung post@ralfj.de 2024-10-06T17:59:19+00:00 urn:sha1:a0215d8e46aab41219dea0bb1cbaaf97dafe2f89 Fundamentally, we have *three* disjoint categories of functions: 1. const-stable functions 2. private/unstable functions that are meant to be callable from const-stable functions 3. functions that can make use of unstable const features This PR implements the following system: - `#[rustc_const_stable]` puts functions in the first category. It may only be applied to `#[stable]` functions. - `#[rustc_const_unstable]` by default puts functions in the third category. The new attribute `#[rustc_const_stable_indirect]` can be added to such a function to move it into the second category. - `const fn` without a const stability marker are in the second category if they are still unstable. They automatically inherit the feature gate for regular calls, it can now also be used for const-calls. Also, several holes in recursive const stability checking are being closed. There's still one potential hole that is hard to avoid, which is when MIR building automatically inserts calls to a particular function in stable functions -- which happens in the panic machinery. Those need to *not* be `rustc_const_unstable` (or manually get a `rustc_const_stable_indirect`) to be sure they follow recursive const stability. But that's a fairly rare and special case so IMO it's fine. The net effect of this is that a `#[unstable]` or unmarked function can be constified simply by marking it as `const fn`, and it will then be const-callable from stable `const fn` and subject to recursive const stability requirements. If it is publicly reachable (which implies it cannot be unmarked), it will be const-unstable under the same feature gate. Only if the function ever becomes `#[stable]` does it need a `#[rustc_const_unstable]` or `#[rustc_const_stable]` marker to decide if this should also imply const-stability. Adding `#[rustc_const_unstable]` is only needed for (a) functions that need to use unstable const lang features (including intrinsics), or (b) `#[stable]` functions that are not yet intended to be const-stable. Adding `#[rustc_const_stable]` is only needed for functions that are actually meant to be directly callable from stable const code. `#[rustc_const_stable_indirect]` is used to mark intrinsics as const-callable and for `#[rustc_const_unstable]` functions that are actually called from other, exposed-on-stable `const fn`. No other attributes are required. 2024-10-04T07:09:20+00:00 Urgau urgau@numericable.fr 2024-10-01T08:25:18+00:00 urn:sha1:a3ffa1eae507809628decc6250b28db6ab167b11 2024-09-22T23:11:29+00:00 Michael Goulet michael@errs.io 2024-09-22T23:05:04+00:00 urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1f 2024-08-26T22:41:57+00:00 Matthias Krüger matthias.krueger@famsik.de 2024-08-26T22:41:57+00:00 urn:sha1:110c3df7fd48904bf714d02201bccb80695fc690 Add `#[warn(unreachable_pub)]` to a bunch of compiler crates By default `unreachable_pub` identifies things that need not be `pub` and tells you to make them `pub(crate)`. But sometimes those things don't need any kind of visibility. So they way I did these was to remove the visibility entirely for each thing the lint identifies, and then add `pub(crate)` back in everywhere the compiler said it was necessary. (Or occasionally `pub(super)` when context suggested that was appropriate.) Tedious, but results in more `pub` removal. There are plenty more crates to do but this seems like enough for a first PR. r? `@compiler-errors` 2024-08-21T05:31:11+00:00 Michael Goulet michael@errs.io 2024-08-21T04:57:58+00:00 urn:sha1:25ff9b6bcbba9e7831eb4d6eba2df6bbcd267c55 2024-08-15T22:46:51+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-07-06T11:31:11+00:00 urn:sha1:6614165eac9532a843f691fe1b7e3c37fa637ebf 2024-07-28T22:26:52+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-07-28T22:13:50+00:00 urn:sha1:84ac80f1921afc243d71fd0caaa4f2838c294102 The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options. 2024-06-18T15:42:11+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2024-06-18T10:35:56+00:00 urn:sha1:7ba82d61eb519c9c8cb8c47a3030a2bd2faaa186 This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle 2024-04-29T00:21:54+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-04-28T22:53:45+00:00 urn:sha1:4814fd0a4bcc2288ba15fb212610bdf3d1d5eb11 2024-03-10T22:15:09+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-03-06T00:02:56+00:00 urn:sha1:7a294e998b66ea6d410a6840cba80347fc4764c2 To match `derive(Diagnostic)`. Also rename `into_diagnostic` as `into_diag`.