rust/compiler/rustc_baked_icu_data, branch 1.89.0

Add `unreachable_pub` to `RUSTC_LINT_FLAGS` for `compiler/` crates.

2025-03-11T02:14:21+00:00

And fix the new errors in the handful of crates that didn't have a `#![warn(unreachable_pub)]`.

Revert "Use workspace lints for crates in `compiler/` #138084"

2025-03-10T10:12:47+00:00

Revert to buy time to consider options that avoids breaking downstream usages of cargo on distributed `rustc-src` artifacts, where such cargo invocations fail due to inability to inherit `lints` from workspace root manifest's `workspace.lints` (this is only valid for the source rust-lang/rust workspace, but not really the distributed `rustc-src` artifacts). This breakage was reported in . This reverts commit 48caf81484b50dca5a5cebb614899a3df81ca898, reversing changes made to c6662879b27f5161e95f39395e3c9513a7b97028.

Add `unreachable_pub` to the default lints for `compiler/` crates.

2025-03-07T21:41:43+00:00

And fix the new errors in the handful of crates that didn't have a `#![warn(unreachable_pub)]`.

Specify rust lints for `compiler/` crates via Cargo.

2025-03-07T21:41:09+00:00

By naming them in `[workspace.lints.rust]` in the top-level `Cargo.toml`, and then making all `compiler/` crates inherit them with `[lints] workspace = true`. (I omitted `rustc_codegen_{cranelift,gcc}`, because they're a bit different.) The advantages of this over the current approach: - It uses a standard Cargo feature, rather than special handling in bootstrap. So, easier to understand, and less likely to get accidentally broken in the future. - It works for proc macro crates. It's a shame it doesn't work for rustc-specific lints, as the comments explain.

Upgrade the compiler to edition 2024

2025-02-22T00:01:48+00:00

Delete the `cfg(not(parallel))` serial compiler

2024-11-12T13:38:58+00:00

Since it's inception a long time ago, the parallel compiler and its cfgs have been a maintenance burden. This was a necessary evil the allow iteration while not degrading performance because of synchronization overhead. But this time is over. Thanks to the amazing work by the parallel working group (and the dyn sync crimes), the parallel compiler has now been fast enough to be shipped by default in nightly for quite a while now. Stable and beta have still been on the serial compiler, because they can't use `-Zthreads` anyways. But this is quite suboptimal: - the maintenance burden still sucks - we're not testing the serial compiler in nightly Because of these reasons, it's time to end it. The serial compiler has served us well in the years since it was split from the parallel one, but it's over now. Let the knight slay one head of the two-headed dragon!

Don't add `warn(unreachable_pub)` to `rustc_baked_icu`.

2024-08-15T22:46:52+00:00

But explain why.

Use `tidy` to sort crate attributes for all compiler crates.

2024-06-12T05:49:10+00:00

We already do this for a number of crates, e.g. `rustc_middle`, `rustc_span`, `rustc_metadata`, `rustc_span`, `rustc_errors`. For the ones we don't, in many cases the attributes are a mess. - There is no consistency about order of attribute kinds (e.g. `allow`/`deny`/`feature`). - Within attribute kind groups (e.g. the `feature` attributes), sometimes the order is alphabetical, and sometimes there is no particular order. - Sometimes the attributes of a particular kind aren't even grouped all together, e.g. there might be a `feature`, then an `allow`, then another `feature`. This commit extends the existing sorting to all compiler crates, increasing consistency. If any new attribute line is added there is now only one place it can go -- no need for arbitrary decisions. Exceptions: - `rustc_log`, `rustc_next_trait_solver` and `rustc_type_ir_macros`, because they have no crate attributes. - `rustc_codegen_gcc`, because it's quasi-external to rustc (e.g. it's ignored in `rustfmt.toml`).

Remove some unused crate dependencies.

2024-06-10T09:55:49+00:00

I found these by setting the `unused_crate_dependencies` lint temporarily to `Warn`.

Bump cfg(bootstrap)s

2023-11-16T00:41:28+00:00