https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=master 2025-08-09T07:47:01+00:00 2025-08-09T07:47:01+00:00 Deadbeef ent3rm4n@gmail.com 2025-08-09T05:24:06+00:00 urn:sha1:ad1113f87ef828b300ebb8fca397efd358580da3 2025-04-01T03:08:57+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-03-20T22:47:43+00:00 urn:sha1:df247968f267d30fb8b048c21f595f2293d8ff62 `ast::Item` has an `ident` field. - It's always non-empty for these item kinds: `ExternCrate`, `Static`, `Const`, `Fn`, `Mod`, `TyAlias`, `Enum`, `Struct`, `Union`, `Trait`, `TraitAlias`, `MacroDef`, `Delegation`. - It's always empty for these item kinds: `Use`, `ForeignMod`, `GlobalAsm`, `Impl`, `MacCall`, `DelegationMac`. There is a similar story for `AssocItemKind` and `ForeignItemKind`. Some sites that handle items check for an empty ident, some don't. This is a very C-like way of doing things, but this is Rust, we have sum types, we can do this properly and never forget to check for the exceptional case and never YOLO possibly empty identifiers (or possibly dummy spans) around and hope that things will work out. The commit is large but it's mostly obvious plumbing work. Some notable things. - `ast::Item` got 8 bytes bigger. This could be avoided by boxing the fields within some of the `ast::ItemKind` variants (specifically: `Struct`, `Union`, `Enum`). I might do that in a follow-up; this commit is big enough already. - For the visitors: `FnKind` no longer needs an `ident` field because the `Fn` within how has one. - In the parser, the `ItemInfo` typedef is no longer needed. It was used in various places to return an `Ident` alongside an `ItemKind`, but now the `Ident` (if present) is within the `ItemKind`. - In a few places I renamed identifier variables called `name` (or `foo_name`) as `ident` (or `foo_ident`), to better match the type, and because `name` is normally used for `Symbol`s. It's confusing to see something like `foo_name.name`. 2025-03-06T20:58:32+00:00 Santiago Pastorino spastorino@gmail.com 2024-10-02T19:35:37+00:00 urn:sha1:05c516446a0f6105ce695da00d5cf5a0eb54e808 2024-12-18T02:38:53+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-12-12T23:29:23+00:00 urn:sha1:2620eb42d72d24baa1ca1056a769862b92c85f7f `rustc_span::symbol` defines some things that are re-exported from `rustc_span`, such as `Symbol` and `sym`. But it doesn't re-export some closely related things such as `Ident` and `kw`. So you can do `use rustc_span::{Symbol, sym}` but you have to do `use rustc_span::symbol::{Ident, kw}`, which is inconsistent for no good reason. This commit re-exports `Ident`, `kw`, and `MacroRulesNormalizedIdent`, and changes many `rustc_span::symbol::` qualifiers in `compiler/` to `rustc_span::`. This is a 200+ net line of code reduction, mostly because many files with two `use rustc_span` items can be reduced to one. 2024-12-12T16:29:40+00:00 Michael Goulet michael@errs.io 2024-09-13T18:00:10+00:00 urn:sha1:3f97c6be8d4b78c9df55804171c588ebfadcb63e 2024-09-22T23:11:29+00:00 Michael Goulet michael@errs.io 2024-09-22T23:05:04+00:00 urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1f 2024-07-28T22:26:52+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-07-28T22:13:50+00:00 urn:sha1:84ac80f1921afc243d71fd0caaa4f2838c294102 The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options. 2024-06-27T19:19:08+00:00 Michael Goulet michael@errs.io 2024-06-27T18:56:57+00:00 urn:sha1:789ee88bd015fde4257464d0120ab57b0d744e0b 2024-06-06T21:46:25+00:00 Jubilee 46493976+workingjubilee@users.noreply.github.com 2024-06-06T21:46:25+00:00 urn:sha1:efd8959ab1bf30c098917af144db72ad08175bc6 [RFC-2011] Allow `core_intrinsics` when activated Fix #120612 2024-06-06T19:30:05+00:00 Caio c410.f3r@gmail.com 2024-06-06T19:30:05+00:00 urn:sha1:a8084dcec1d2d36c286ca0e2c384e7bf5cfeffce