https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=try 2025-06-20T03:17:39+00:00 2025-06-20T03:17:39+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-05-29T14:37:27+00:00 urn:sha1:4a1f445142e2446d8139f91cf85d4e93083b33ef This avoids some symbol interning and `to_string` conversions. 2025-05-26T16:07:15+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-05-26T15:42:51+00:00 urn:sha1:6973fa08a3a4044c87b9da9e66cb1ca17f89b889 It's barely used, and the places that use it are better if they don't. 2025-04-09T23:30:55+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-08T02:23:07+00:00 urn:sha1:1b3fc585cb48c71dbaf1677af6d6698977b436cd It bugs me when variables of type `Ident` are called `name`. It leads to silly things like `name.name`. `Ident` variables should be called `ident`, and `name` should be used for variables of type `Symbol`. This commit improves things by by doing `s/name/ident/` on a bunch of `Ident` variables. Not all of them, but a decent chunk. 2025-04-01T05:07:23+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-01T03:49:58+00:00 urn:sha1:ec10833609aa63327437aabfaedfbe8a0edcc4d9 2025-04-01T03:08:57+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-03-20T22:47:43+00:00 urn:sha1:df247968f267d30fb8b048c21f595f2293d8ff62 `ast::Item` has an `ident` field. - It's always non-empty for these item kinds: `ExternCrate`, `Static`, `Const`, `Fn`, `Mod`, `TyAlias`, `Enum`, `Struct`, `Union`, `Trait`, `TraitAlias`, `MacroDef`, `Delegation`. - It's always empty for these item kinds: `Use`, `ForeignMod`, `GlobalAsm`, `Impl`, `MacCall`, `DelegationMac`. There is a similar story for `AssocItemKind` and `ForeignItemKind`. Some sites that handle items check for an empty ident, some don't. This is a very C-like way of doing things, but this is Rust, we have sum types, we can do this properly and never forget to check for the exceptional case and never YOLO possibly empty identifiers (or possibly dummy spans) around and hope that things will work out. The commit is large but it's mostly obvious plumbing work. Some notable things. - `ast::Item` got 8 bytes bigger. This could be avoided by boxing the fields within some of the `ast::ItemKind` variants (specifically: `Struct`, `Union`, `Enum`). I might do that in a follow-up; this commit is big enough already. - For the visitors: `FnKind` no longer needs an `ident` field because the `Fn` within how has one. - In the parser, the `ItemInfo` typedef is no longer needed. It was used in various places to return an `Ident` alongside an `ItemKind`, but now the `Ident` (if present) is within the `ItemKind`. - In a few places I renamed identifier variables called `name` (or `foo_name`) as `ident` (or `foo_ident`), to better match the type, and because `name` is normally used for `Symbol`s. It's confusing to see something like `foo_name.name`. 2025-02-08T22:12:13+00:00 bjorn3 17426603+bjorn3@users.noreply.github.com 2025-02-08T22:12:13+00:00 urn:sha1:1fcae03369abb4c2cc180cd5a49e1f4440a81300 2024-12-18T02:38:53+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-12-12T23:29:23+00:00 urn:sha1:2620eb42d72d24baa1ca1056a769862b92c85f7f `rustc_span::symbol` defines some things that are re-exported from `rustc_span`, such as `Symbol` and `sym`. But it doesn't re-export some closely related things such as `Ident` and `kw`. So you can do `use rustc_span::{Symbol, sym}` but you have to do `use rustc_span::symbol::{Ident, kw}`, which is inconsistent for no good reason. This commit re-exports `Ident`, `kw`, and `MacroRulesNormalizedIdent`, and changes many `rustc_span::symbol::` qualifiers in `compiler/` to `rustc_span::`. This is a 200+ net line of code reduction, mostly because many files with two `use rustc_span` items can be reduced to one. 2024-10-25T18:31:40+00:00 Ralf Jung post@ralfj.de 2024-10-07T15:27:37+00:00 urn:sha1:3854e16fa2b2ee004ff2cbc71b28f9de28306942 2024-09-22T23:11:29+00:00 Michael Goulet michael@errs.io 2024-09-22T23:05:04+00:00 urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1f 2024-07-28T22:26:52+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-07-28T22:13:50+00:00 urn:sha1:84ac80f1921afc243d71fd0caaa4f2838c294102 The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options.