rust/compiler/rustc_builtin_macros/src/test_harness.rs, branch perf-tmphttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=perf-tmp2025-09-21T17:12:18+00:00Add panic=immediate-abort2025-09-21T17:12:18+00:00Ben Kimockkimockb@gmail.com2025-09-07T16:31:35+00:00urn:sha1:888679013d1f424adef06267f3630069b4cabd40Move more early buffered lints to dyn lint diagnostics (1/N)2025-09-14T10:38:11+00:00León Orell Valerian Liehrme@fmease.dev2025-08-26T12:24:22+00:00urn:sha1:2e816736efaebf1f4666efac1817bcccd78a3e52Prevent impossible combinations in `ast::ModKind`.2025-08-19T11:57:31+00:00Nicholas Nethercoten.nethercote@gmail.com2025-08-19T05:06:48+00:00urn:sha1:bfd5d59f976f6c3b6dbe486724a0bb2054aad94b
`ModKind::Loaded` has an `inline` field and a `had_parse_error` field.
If the `inline` field is `Inline::Yes` then `had_parse_error` must be
`Ok(())`.
This commit moves the `had_parse_error` field into the `Inline::No`
variant. This makes it impossible to create the nonsensical combination
of `inline == Inline::Yes` and `had_parse_error = Err(_)`.
remove `P`2025-08-09T07:47:01+00:00Deadbeefent3rm4n@gmail.com2025-08-09T05:24:06+00:00urn:sha1:ad1113f87ef828b300ebb8fca397efd358580da3Auto merge of #142706 - fee1-dead-contrib:push-zsznlqyrzsqo, r=oli-obk2025-06-22T14:03:44+00:00borsbors@rust-lang.org2025-06-22T14:03:44+00:00urn:sha1:c2ec7532eed172e79800d28f087727c4b048badd
completely deduplicate `Visitor` and `MutVisitor`
r? oli-obk
This closes rust-lang/rust#127615.
### Discussion
> * Give every `MutVisitor::visit_*` method a corresponding `flat_map_*` method.
Not every AST node exists in a location where they can be mapped to multiple instances of themselves. Not every AST node exists in a location where they can be removed from existence (e.g. `filter_map_expr`). I don't think this is doable.
> * Give every `MutVisitor::visit_*` method a corresponding `Visitor` method and vice versa
The only three remaining method-level asymmetries after this PR are `visit_stmt` and `visit_nested_use_tree` (only on `Visitor`) and `visit_span` (only on `MutVisitor`).
`visit_stmt` doesn't seem applicable to `MutVisitor` because `walk_flat_map_stmt_kind` will ask `flat_map_item` / `filter_map_expr` to potentially turn a single `Stmt` to multiple based on what a visitor wants. So only using `flat_map_stmt` seems appropriate.
`visit_nested_use_tree` is used for `rustc_resolve` to track stuff. Not useful for `MutVisitor` for now.
`visit_span` is currently not used for `MutVisitor` already, it was just kept in case we want to revive rust-lang/rust#127241. cc `@cjgillot` maybe we could remove for now and re-insert later if we find a use-case? It does involve some extra effort to maintain.
* Remaining FIXMEs
`visit_lifetime` has an extra param for `Visitor` that's not in `MutVisitor`. This is again something only used by `rustc_resolve`. I think we can keep that symmetry for now.
Use a symbol for `ExpansionConfig::crate_name`.2025-06-20T03:17:39+00:00Nicholas Nethercoten.nethercote@gmail.com2025-05-29T14:37:27+00:00urn:sha1:4a1f445142e2446d8139f91cf85d4e93083b33ef
This avoids some symbol interning and `to_string` conversions.
remove `walk_item_kind` from `MutVisitor`2025-06-19T05:50:15+00:00Deadbeefent3rm4n@gmail.com2025-06-11T14:20:28+00:00urn:sha1:4eaca5d1def1347e3c31bd549f419258a2bd6004
just using `walk_item` instead would be okay.
avoid some usages of `&mut P<T>` in AST visitors2025-05-29T04:54:55+00:00Deadbeefent3rm4n@gmail.com2025-05-27T07:17:17+00:00urn:sha1:367a877147024987bfec25af513cb1233894135dMove `ast::Item::ident` into `ast::ItemKind`.2025-04-01T03:08:57+00:00Nicholas Nethercoten.nethercote@gmail.com2025-03-20T22:47:43+00:00urn:sha1:df247968f267d30fb8b048c21f595f2293d8ff62
`ast::Item` has an `ident` field.
- It's always non-empty for these item kinds: `ExternCrate`, `Static`,
`Const`, `Fn`, `Mod`, `TyAlias`, `Enum`, `Struct`, `Union`,
`Trait`, `TraitAlias`, `MacroDef`, `Delegation`.
- It's always empty for these item kinds: `Use`, `ForeignMod`,
`GlobalAsm`, `Impl`, `MacCall`, `DelegationMac`.
There is a similar story for `AssocItemKind` and `ForeignItemKind`.
Some sites that handle items check for an empty ident, some don't. This
is a very C-like way of doing things, but this is Rust, we have sum
types, we can do this properly and never forget to check for the
exceptional case and never YOLO possibly empty identifiers (or possibly
dummy spans) around and hope that things will work out.
The commit is large but it's mostly obvious plumbing work. Some notable
things.
- `ast::Item` got 8 bytes bigger. This could be avoided by boxing the
fields within some of the `ast::ItemKind` variants (specifically:
`Struct`, `Union`, `Enum`). I might do that in a follow-up; this
commit is big enough already.
- For the visitors: `FnKind` no longer needs an `ident` field because
the `Fn` within how has one.
- In the parser, the `ItemInfo` typedef is no longer needed. It was used
in various places to return an `Ident` alongside an `ItemKind`, but
now the `Ident` (if present) is within the `ItemKind`.
- In a few places I renamed identifier variables called `name` (or
`foo_name`) as `ident` (or `foo_ident`), to better match the type, and
because `name` is normally used for `Symbol`s. It's confusing to see
something like `foo_name.name`.
Implement `#[define_opaque]` attribute for functions.2025-03-11T12:05:02+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2024-07-26T10:04:02+00:00urn:sha1:cb4751d4b87e1c8ebdeb381abe3785486a59968e