https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.59.0 2021-12-30T13:53:41+00:00 2021-12-30T13:53:41+00:00 bjorn3 bjorn3@users.noreply.github.com 2021-12-30T13:53:41+00:00 urn:sha1:a8e6d5b04d844a8b540a772dec4f6a233f307c35 2021-12-20T17:56:35+00:00 bjorn3 bjorn3@users.noreply.github.com 2021-12-20T17:56:35+00:00 urn:sha1:3426a730ffc78bea3fa45593a383647c0774fe57 2021-09-19T11:56:58+00:00 bjorn3 bjorn3@users.noreply.github.com 2021-09-19T11:56:58+00:00 urn:sha1:86f9bcfb8e5863fe51699dc9edebe76fb97078d2 2021-09-03T00:23:10+00:00 bors bors@rust-lang.org 2021-09-03T00:23:10+00:00 urn:sha1:97f2698484c2d668b2f356a6c2252e5f08472234 Path remapping: Make behavior of diagnostics output dependent on presence of --remap-path-prefix. This PR fixes a regression (#87745) with `--remap-path-prefix` where the flag stopped causing diagnostic messages to be remapped as well. The regression was introduced in https://github.com/rust-lang/rust/pull/83813 where we erroneously assumed that remapping of diagnostic messages was not desired anymore (because #70642 partially undid that functionality with nobody objecting). The issue is fixed by making `--remap-path-prefix` remap diagnostic messages again, including for paths that have been remapped in upstream crates (e.g. the standard library). This means that "sysroot-localization" (implemented in #70642) is also disabled if `rustc` is invoked with `--remap-path-prefix`. The assumption is that once someone starts explicitly remapping paths they also don't want paths to their local Rust installation in their build output. In the future we might want to give more fine-grained control over this behavior via compiler flags (see https://github.com/rust-lang/rfcs/pull/3127 for a related RFC). For now this PR is intended as a regression fix. This PR is an alternative to https://github.com/rust-lang/rust/pull/88191, which makes diagnostic messages be remapped unconditionally. That approach, however, would effectively revert #70642. Fixes https://github.com/rust-lang/rust/issues/87745. cc `@cbeuw` r? `@ghost` 2021-08-29T21:44:09+00:00 Eduard-Mihai Burtescu eddyb@lyken.rs 2021-08-25T15:05:10+00:00 urn:sha1:8e6d126b7d69281072f16dcc3cfff140e8947c58 2021-08-27T09:50:44+00:00 Michael Woerister michaelwoerister@posteo 2021-08-26T10:46:01+00:00 urn:sha1:af1b65cb18d5fa1358d1ae7a8ed3b1f7c635b6b5 2021-08-15T20:17:37+00:00 Aaron Hill aa1ronham@gmail.com 2021-08-12T21:46:58+00:00 urn:sha1:179fd38bb593896a8c1cb15bd50faebecd9f601a 2021-08-06T14:26:56+00:00 bjorn3 bjorn3@users.noreply.github.com 2021-08-06T14:26:56+00:00 urn:sha1:279f486960edc43246ea413970f587a82365cca7 2021-07-07T09:14:20+00:00 bjorn3 bjorn3@users.noreply.github.com 2021-07-07T09:14:20+00:00 urn:sha1:d531f3d6eef9eef1a699b3ffb6dce4e911690dca 2021-05-05T14:31:28+00:00 Andy Wang cbeuw.andy@gmail.com 2021-04-19T22:27:02+00:00 urn:sha1:5417b45c2676dcd396f007bd89ed0cd55d085768