rust/compiler/rustc_codegen_gcc/src/errors.rs, branch 1.82.0

Remove redundant argument from `subdiagnostic` method

2024-06-18T15:42:11+00:00

Use a dedicated type instead of a reference for the diagnostic context

2024-06-18T15:42:11+00:00

This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle

Rename `IntoDiagnostic` as `Diagnostic`.

2024-03-10T22:15:09+00:00

To match `derive(Diagnostic)`. Also rename `into_diagnostic` as `into_diag`.

Merge commit 'b385428e3ddf330805241e7758e773f933357c4b' into subtree-update_cg_gcc_2024-03-05

2024-03-05T18:58:36+00:00

Rename `DiagnosticArg{,Map,Name,Value}` as `DiagArg{,Map,Name,Value}`.

2024-02-27T21:55:37+00:00

Rename `DiagnosticBuilder` as `Diag`.

2024-02-27T21:55:35+00:00

Much better! Note that this involves renaming (and updating the value of) `DIAGNOSTIC_BUILDER` in clippy.

errors: only eagerly translate subdiagnostics

2024-02-15T10:34:41+00:00

Subdiagnostics don't need to be lazily translated, they can always be eagerly translated. Eager translation is slightly more complex as we need to have a `DiagCtxt` available to perform the translation, which involves slightly more threading of that context. This slight increase in complexity should enable later simplifications - like passing `DiagCtxt` into `AddToDiagnostic` and moving Fluent messages into the diagnostic structs rather than having them in separate files (working on that was what led to this change). Signed-off-by: David Wood

Remove the lifetime from `DiagnosticArgValue`.

2024-01-30T07:46:06+00:00

Because it's almost always static. This makes `impl IntoDiagnosticArg for DiagnosticArgValue` trivial, which is nice. There are a few diagnostics constructed in `compiler/rustc_mir_build/src/check_unsafety.rs` and `compiler/rustc_mir_transform/src/errors.rs` that now need symbols converted to `String` with `to_string` instead of `&str` with `as_str`, but that' no big deal, and worth it for the simplifications elsewhere.

Rename some `Diagnostic` setters.

2024-01-03T08:40:20+00:00

`Diagnostic` has 40 methods that return `&mut Self` and could be considered setters. Four of them have a `set_` prefix. This doesn't seem necessary for a type that implements the builder pattern. This commit removes the `set_` prefixes on those four methods.

Add `level` arg to `into_diagnostic`.

2023-12-18T22:19:25+00:00

And make all hand-written `IntoDiagnostic` impls generic, by using `DiagnosticBuilder::new(dcx, level, ...)` instead of e.g. `dcx.struct_err(...)`. This means the `create_*` functions are the source of the error level. This change will let us remove `struct_diagnostic`. Note: `#[rustc_lint_diagnostics]` is added to `DiagnosticBuilder::new`, it's necessary to pass diagnostics tests now that it's used in `into_diagnostic` functions.