rust/compiler/rustc_codegen_llvm/src/debuginfo/metadata, branch 1.86.0

debuginfo: Set bitwidth appropriately in enum variant tags

2025-02-12T18:01:42+00:00

Previously, we unconditionally set the bitwidth to 128-bits, the largest an discrimnator would possibly be. Then, LLVM would cut down the constant by chopping off leading zeroes before emitting the DWARF. LLVM only supported 64-bit descriminators, so this would also have occasionally resulted in truncated data (or an assert) if more than 64-bits were used. LLVM added support for 128-bit enumerators in llvm/llvm-project#125578 That patchset also trusts the constant to describe how wide the variant tag is. As a result, we went from emitting tags that looked like: DW_AT_discr_value (0xfe) (`form1`) to emitting tags that looked like: DW_AT_discr_value (<0x10> fe ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00 ) This makes the `DW_AT_discr_value` encode at the bitwidth of the tag, which: 1. Is probably closer to our intentions in terms of describing the data. 2. Doesn't invoke the 128-bit support which may not be supported by all debuggers / downstream tools. 3. Will result in smaller debug information.

Use ExistentialTraitRef throughout codegen

2025-01-30T15:34:00+00:00

Use gimli to get the values of DWARF constants needed by codegen

2025-01-05T11:07:48+00:00

The `gimli` crate is already a dependency of `thorin-dwp`, which is already a dependency of `rustc_codegen_ssa`.

force enum `DISCR_*` to `const u64` to allow for inspection via LLDB's `SBTypeStaticField::GetConstantValue()`

2024-12-31T01:01:48+00:00

fix outdated comment

2024-12-18T10:01:54+00:00

Co-authored-by: Camille Gillot

make no-variant types a dedicated Variants variant

2024-12-18T10:01:54+00:00

Variants::Single: do not use invalid VariantIdx for uninhabited enums

2024-12-18T10:00:21+00:00

Auto merge of #104342 - mweber15:add_file_location_to_more_types, r=wesleywiser

2024-12-03T12:49:57+00:00

Require `type_map::stub` callers to supply file information This change attaches file information (`DIFile` reference and line number) to struct debug info nodes. Before: ``` ; foo.ll ... !5 = !DIFile(filename: "", directory: "") ... !16 = !DICompositeType(tag: DW_TAG_structure_type, name: "MyType", scope: !2, file: !5, size: 32, align: 32, elements: !17, templateParams: !19, identifier: "4cb373851db92e732c4cb5651b886dd0") ... ``` After: ``` ; foo.ll ... !3 = !DIFile(filename: "foo.rs", directory: "/home/matt/src/rust98678", checksumkind: CSK_SHA1, checksum: "bcb9f08512c8f3b8181ef4726012bc6807bc9be4") ... !16 = !DICompositeType(tag: DW_TAG_structure_type, name: "MyType", scope: !2, file: !3, line: 3, size: 32, align: 32, elements: !17, templateParams: !19, identifier: "9e5968c7af39c148acb253912b7f409f") ... ``` Fixes #98678 r? `@wesleywiser`

use `TypingEnv` when no `infcx` is available

2024-11-18T09:38:56+00:00

the behavior of the type system not only depends on the current assumptions, but also the currentnphase of the compiler. This is mostly necessary as we need to decide whether and how to reveal opaque types. We track this via the `TypingMode`.

Clean up use requirements after rebasing

2024-11-07T03:26:18+00:00