rust/compiler/rustc_codegen_llvm/src/debuginfo, branch 1.70.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.70.02023-05-20T00:01:39+00:00debuginfo: split method declaration and definition2023-05-20T00:01:39+00:00Josh Stonejistone@redhat.com2023-05-03T22:52:31+00:00urn:sha1:ec1d458777fbb49ae4be1e285da8206cbb6c3456
When we're adding a method to a type DIE, we only want a DW_AT_declaration
there, because LLVM LTO can't unify type definitions when a child DIE is a
full subprogram definition. Now the subprogram definition gets added at the
CU level with a specification link back to the abstract declaration.
(cherry picked from commit 10b69dde3fd15334ea2382d2dc9e9a261de1afaf)
Auto merge of #109862 - klensy:llvm-dd, r=nikic2023-04-08T15:57:59+00:00borsbors@rust-lang.org2023-04-08T15:57:59+00:00urn:sha1:dd2b19539ea4d62a150cf13d45942e58b6b44e54
llvm: replace some deprecated functions, add fixmes
Replace some deprecated llvm functions, add FIXME's (for simpler future work), replace some rust custom functions with llvm ones.
review2023-04-05T12:08:17+00:00klensyklensy@users.noreply.github.com2023-04-05T12:08:17+00:00urn:sha1:c0bc00174f0b033a689a12c108f0abddc3420f9fAuto merge of #109808 - jyn514:debuginfo-options, r=michaelwoerister2023-04-04T20:01:05+00:00borsbors@rust-lang.org2023-04-04T20:01:05+00:00urn:sha1:700938c0781c9f135244bb1ec846fe1a5e03ae7d
Extend -Cdebuginfo with new options and named aliases
This is a rebase of https://github.com/rust-lang/rust/pull/83947, along with my best guess at what the new options mean. I tried to follow the LLVM source code to get a better idea but ran into quite a lot of trouble (https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/go-to-definition.20in.20src.2Fllvm-project.3F). The description for the original PR follows below.
Note that the changes in this PR have already been through FCP: https://github.com/rust-lang/rust/pull/83947#issuecomment-878384979
Closes https://github.com/rust-lang/rust/pull/109311. Helps with https://github.com/rust-lang/rust/pull/104968.
r? `@michaelwoerister` cc `@cuviper`
---
The -Cdebuginfo=1 option was never line tables only and can't be due to backwards compatibility issues. This was clarified and an option for emitting line tables only was added. Additionally an option for emitting line info directives only was added, which is needed for some targets, i.e. nvptx. The debug info options should now behave similarly to clang's debug info options.
Fix https://github.com/rust-lang/rust/issues/60020
Fix https://github.com/rust-lang/rust/issues/64405
replace LLVMRustMetadataAsValue with LLVMMetadataAsValue2023-04-04T12:12:35+00:00klensyklensy@users.noreply.github.com2023-04-02T14:52:38+00:00urn:sha1:c53a9faa6fdcdf8776646e837272ea0a85bf8179replace deprecated LLVMSetCurrentDebugLocation with LLVMSetCurrentDebugLocation22023-04-04T12:12:32+00:00klensyklensy@users.noreply.github.com2023-04-02T12:20:00+00:00urn:sha1:0b5f9ac73e087b3728f0fcf53d541d4e80773732Use `&IndexSlice` instead of `&IndexVec` where possible2023-04-03T00:35:37+00:00Scott McMurrayscottmcm@users.noreply.github.com2023-03-31T07:32:44+00:00urn:sha1:a2ee7592d6b7c0daa62b7870ade85e0cc0acca05
All the same reasons as for `[T]`: more general, less pointer chasing, and `&mut IndexSlice` emphasizes that it doesn't change *length*.
Preserve, clarify, and extend debug information2023-03-31T11:28:39+00:00Julia Tatztatz.j@northeastern.edu2021-04-06T20:00:35+00:00urn:sha1:0504a333837e10f19454901fd060c0f99bf8f5b7
`-Cdebuginfo=1` was never line tables only and
can't be due to backwards compatibility issues.
This was clarified and an option for line tables only
was added. Additionally an option for line info
directives only was added, which is well needed for
some targets. The debug info options should now
behave the same as clang's debug info options.
Update `ty::VariantDef` to use `IndexVec<FieldIdx, FieldDef>`2023-03-30T16:23:40+00:00Scott McMurrayscottmcm@users.noreply.github.com2023-03-29T06:32:25+00:00urn:sha1:4abb45552992da2c30df9626c1b522b3d10f789b
And while doing the updates for that, also uses `FieldIdx` in `ProjectionKind::Field` and `TypeckResults::field_indices`.
There's more places that could use it (like `rustc_const_eval` and `LayoutS`), but I tried to keep this PR from exploding to *even more* places.
Part 2/? of https://github.com/rust-lang/compiler-team/issues/606
Move `mir::Field` → `abi::FieldIdx`2023-03-29T05:22:37+00:00Scott McMurrayscottmcm@users.noreply.github.com2023-03-28T19:32:57+00:00urn:sha1:5bbaeadc013cae79e440fb5d3da2175c83cb36e4
The first PR for https://github.com/rust-lang/compiler-team/issues/606
This is just the move-and-rename, because it's plenty big-and-bitrotty already. Future PRs will start using `FieldIdx` more broadly, and concomitantly removing `FieldIdx::new`s.