rust/compiler/rustc_codegen_llvm/src/errors.rs, branch 1.81.0

Remove redundant argument from `subdiagnostic` method

2024-06-18T15:42:11+00:00

Use a dedicated type instead of a reference for the diagnostic context

2024-06-18T15:42:11+00:00

This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle

Use an error struct instead of a panic

2024-05-15T09:14:45+00:00

Rename `IntoDiagnostic` as `Diagnostic`.

2024-03-10T22:15:09+00:00

To match `derive(Diagnostic)`. Also rename `into_diagnostic` as `into_diag`.

Rename `DiagnosticBuilder` as `Diag`.

2024-02-27T21:55:35+00:00

Much better! Note that this involves renaming (and updating the value of) `DIAGNOSTIC_BUILDER` in clippy.

Overhaul `Diagnostic` args.

2024-02-22T01:51:05+00:00

First, introduce a typedef `DiagnosticArgMap`. Second, make the `args` field public, and remove the `args` getter and `replace_args` setter. These were necessary previously because the getter had a `#[allow(rustc::potential_query_instability)]` attribute, but that was removed in #120931 when the args were changed from `FxHashMap` to `FxIndexMap`. (All the other `Diagnostic` fields are public.)

errors: only eagerly translate subdiagnostics

2024-02-15T10:34:41+00:00

Subdiagnostics don't need to be lazily translated, they can always be eagerly translated. Eager translation is slightly more complex as we need to have a `DiagCtxt` available to perform the translation, which involves slightly more threading of that context. This slight increase in complexity should enable later simplifications - like passing `DiagCtxt` into `AddToDiagnostic` and moving Fluent messages into the diagnostic structs rather than having them in separate files (working on that was what led to this change). Signed-off-by: David Wood

Rollup merge of #120631 - saethlin:invalid-target-ice, r=compiler-errors

2024-02-06T18:40:08+00:00

Emit a diagnostic for invalid target options This turns the ICE in https://github.com/rust-lang/rust/issues/120625 into a translatable diagnostic.

Emit a diagnostic for invalid target options

2024-02-04T03:03:25+00:00

`Diagnostic` cleanups

2024-02-02T22:02:50+00:00

- `emitted_at` isn't used outside the crate. - `code` and `messages` are public fields, so there's no point have trivial getters/setters for them. - `suggestions` is public, so the comment about "functionality on `Diagnostic`" isn't needed.