rust/compiler/rustc_codegen_llvm/src/errors.rs, branch 1.82.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.82.02024-08-26T22:41:57+00:00Rollup merge of #126013 - nnethercote:unreachable_pub, r=Urgau2024-08-26T22:41:57+00:00Matthias Krügermatthias.krueger@famsik.de2024-08-26T22:41:57+00:00urn:sha1:110c3df7fd48904bf714d02201bccb80695fc690
Add `#[warn(unreachable_pub)]` to a bunch of compiler crates
By default `unreachable_pub` identifies things that need not be `pub` and tells you to make them `pub(crate)`. But sometimes those things don't need any kind of visibility. So they way I did these was to remove the visibility entirely for each thing the lint identifies, and then add `pub(crate)` back in everywhere the compiler said it was necessary. (Or occasionally `pub(super)` when context suggested that was appropriate.) Tedious, but results in more `pub` removal.
There are plenty more crates to do but this seems like enough for a first PR.
r? `@compiler-errors`
Always use ar_archive_writer for import libs2024-08-17T19:10:46+00:00Chris Dentonchris@chrisdenton.dev2024-08-16T19:32:22+00:00urn:sha1:0156eb57a152003c0c82552229747b3d04e1fddcAdd `warn(unreachable_pub)` to `rustc_codegen_llvm`.2024-08-15T22:46:57+00:00Nicholas Nethercoten.nethercote@gmail.com2024-07-06T12:26:42+00:00urn:sha1:61627438ebb72977c8480a2d8b573137cfecefb1Move mingw dlltool invocation to cg_ssa2024-07-30T10:33:33+00:00bjorn317426603+bjorn3@users.noreply.github.com2024-07-25T20:17:59+00:00urn:sha1:216686bfa5025f2b4cd712c8d933c4d05599816eReformat `use` declarations.2024-07-28T22:26:52+00:00Nicholas Nethercoten.nethercote@gmail.com2024-07-28T22:13:50+00:00urn:sha1:84ac80f1921afc243d71fd0caaa4f2838c294102
The previous commit updated `rustfmt.toml` appropriately. This commit is
the outcome of running `x fmt --all` with the new formatting options.
Remove redundant argument from `subdiagnostic` method2024-06-18T15:42:11+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2024-06-18T11:10:18+00:00urn:sha1:3f34196839730cfb5b241667cfcc9b94599ea0c1Use a dedicated type instead of a reference for the diagnostic context2024-06-18T15:42:11+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2024-06-18T10:35:56+00:00urn:sha1:7ba82d61eb519c9c8cb8c47a3030a2bd2faaa186
This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle
Use an error struct instead of a panic2024-05-15T09:14:45+00:00Alice Ryhlaliceryhl@google.com2024-05-15T08:01:55+00:00urn:sha1:b780fa9219c4c921e3334971a9e673e22cbea375Rename `IntoDiagnostic` as `Diagnostic`.2024-03-10T22:15:09+00:00Nicholas Nethercoten.nethercote@gmail.com2024-03-06T00:02:56+00:00urn:sha1:7a294e998b66ea6d410a6840cba80347fc4764c2
To match `derive(Diagnostic)`.
Also rename `into_diagnostic` as `into_diag`.
Rename `DiagnosticBuilder` as `Diag`.2024-02-27T21:55:35+00:00Nicholas Nethercoten.nethercote@gmail.com2024-02-22T23:20:45+00:00urn:sha1:899cb40809a85eb9d89f6da3268713b83175360a
Much better!
Note that this involves renaming (and updating the value of)
`DIAGNOSTIC_BUILDER` in clippy.