https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.66.1 2022-09-01T14:54:27+00:00 2022-09-01T14:54:27+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2022-08-31T13:09:26+00:00 urn:sha1:ee3c8350189de045ec71997874eaa6cebf99fbf3 2022-07-06T05:41:53+00:00 Alan Egerton eggyal@gmail.com 2022-06-17T12:15:00+00:00 urn:sha1:4f0a64736b94a84da4272867366b8679b585e603 2021-12-16T19:43:32+00:00 LegionMammal978 mattlloydhouse@gmail.com 2021-12-14T18:49:49+00:00 urn:sha1:4937a55dfb19e804c3c974e5341b70dcd76192d4 See #91867 for more information. 2021-10-01T21:17:19+00:00 Guillaume Gomez guillaume.gomez@huawei.com 2021-09-30T17:38:50+00:00 urn:sha1:759eba0a08ef80f958e671e822ad02e2b5409946 2021-10-01T16:18:16+00:00 Manish Goregaokar manishsmail@gmail.com 2021-10-01T16:18:16+00:00 urn:sha1:6f1e93058137eb606cbee5ef778d30b379903f7c Add `pie` as another `relocation-model` value MCP: https://github.com/rust-lang/compiler-team/issues/461 2021-10-01T06:06:42+00:00 Marcel Hlopko hlopko@google.com 2021-09-10T13:11:56+00:00 urn:sha1:198d90786b9fb429928d70c423bad5d65374a532 2021-09-18T01:41:33+00:00 Eduard-Mihai Burtescu eddyb@lyken.rs 2021-09-01T21:29:15+00:00 urn:sha1:c1837ef1c58edd48c81341126ecc94e7adc5bd3d 2021-09-18T01:41:29+00:00 Eduard-Mihai Burtescu eddyb@lyken.rs 2021-09-01T21:09:34+00:00 urn:sha1:e9b68304efc447a7bcd35b06511f6dfdfe9da16d 2021-09-01T22:17:14+00:00 Eduard-Mihai Burtescu eddyb@lyken.rs 2021-08-30T14:38:27+00:00 urn:sha1:4ce933f13fd5af5a344cbc435d94253eae9dc33d 2021-08-21T00:10:41+00:00 Patrick Walton pcwalton@fb.com 2021-08-20T23:42:45+00:00 urn:sha1:c17b1904a90002b5bdb6e2fdcd76e61a1ad3cd7a This matches Clang's behavior: https://github.com/llvm/llvm-project/blob/973cb2c326be9f256da0897c4d2ef117dc22761d/clang/lib/CodeGen/CodeGenModule.cpp#L1038-L1040 Even if `dso_local` were properly supported in this way on macOS, it seems incorrect to add this annotation as liberally as we did. The `dso_local` annotation is for symbols that ultimately end up in the same linkage unit, but we were adding this annotation even for `static` values inside `extern` blocks marked with `#[link(type="framework")]`, which should be considered dynamically linked. Note that Clang likewise avoids emitting `dso_local` for `dllimport` symbols: https://github.com/llvm/llvm-project/blob/973cb2c326be9f256da0897c4d2ef117dc22761d/clang/lib/CodeGen/CodeGenModule.cpp#L1005-L1007 This issue caused breakage in the `ring` crate, which links to a symbol defined in `Security.framework` that ultimately resolves to address `0x0`: https://github.com/briansmith/ring/blob/b94d61e044b42827fefd71d5f61e8c58a7659870/src/rand.rs#L390 For this symbol, the use of `dso_local` causes LLVM to emit a relocation of type `X86_64_RELOC_SIGNED`, which is a 32-bit signed PC-relative offset. If the binary is large enough, `0x0` might be out of range, and the link will fail. Avoiding `dso_local` causes LLVM to use the GOT instead, emitting a relocation of type `X86_64_RELOC_GOT_LOAD`, which will properly handle the large offset and cause the link to succeed. As a side note, the static relocation model is effectively deprecated for security reasons on macOS, as it prohibits PIE. It's also completely unsupported on Apple Silicon, so I don't think it's worth going to the effort of properly supporting this model on that platform.