rust/compiler/rustc_codegen_llvm/src, branch 1.83.0

Rollup merge of #131626 - matthiaskrgr:dont_string, r=lqd

2024-10-13T02:38:38+00:00

remove a couple of redundant String to String conversion

2024-10-12T20:07:46+00:00

`LLVMConstInt` only allows integer types

2024-10-12T15:02:15+00:00

Rollup merge of #124874 - jedbrown:float-mul-add-fast, r=saethlin

2024-10-12T03:57:44+00:00

intrinsics fmuladdf{32,64}: expose llvm.fmuladd.* semantics Add intrinsics `fmuladd{f32,f64}`. This computes `(a * b) + c`, to be fused if the code generator determines that (i) the target instruction set has support for a fused operation, and (ii) that the fused operation is more efficient than the equivalent, separate pair of `mul` and `add` instructions. https://llvm.org/docs/LangRef.html#llvm-fmuladd-intrinsic The codegen_cranelift uses the `fma` function from libc, which is a correct implementation, but without the desired performance semantic. I think this requires an update to cranelift to expose a suitable instruction in its IR. I have not tested with codegen_gcc, but it should behave the same way (using `fma` from libc). --- This topic has been discussed a few times on Zulip and was suggested, for example, by `@workingjubilee` in [Effect of fma disabled](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Effect.20of.20fma.20disabled/near/274179331).

Rollup merge of #131543 - Zalathar:goodbye-llvm-17, r=petrochenkov

2024-10-11T21:53:49+00:00

coverage: Remove code related to LLVM 17 In-tree LLVM is 19, and the minimum external LLVM was increased to 18 in #130487.

intrinsics.fmuladdf{16,32,64,128}: expose llvm.fmuladd.* semantics

2024-10-11T21:32:56+00:00

Add intrinsics `fmuladd{f16,f32,f64,f128}`. This computes `(a * b) + c`, to be fused if the code generator determines that (i) the target instruction set has support for a fused operation, and (ii) that the fused operation is more efficient than the equivalent, separate pair of `mul` and `add` instructions. https://llvm.org/docs/LangRef.html#llvm-fmuladd-intrinsic MIRI support is included for f32 and f64. The codegen_cranelift uses the `fma` function from libc, which is a correct implementation, but without the desired performance semantic. I think this requires an update to cranelift to expose a suitable instruction in its IR. I have not tested with codegen_gcc, but it should behave the same way (using `fma` from libc).

Rollup merge of #131519 - davidlattimore:intrinsics-default-vis, r=Urgau

2024-10-11T13:36:52+00:00

Use Default visibility for rustc-generated C symbol declarations Non-default visibilities should only be used for definitions, not declarations, otherwise linking can fail. This is based on https://github.com/rust-lang/rust/pull/123994. Issue https://github.com/rust-lang/rust/issues/123427 When I changed `default-hidden-visibility` to `default-visibility` in https://github.com/rust-lang/rust/pull/130005, I updated all places in the code that used `default-hidden-visibility`, replicating the hidden-visibility bug to also happen for protected visibility. Without this change, trying to build rustc with `-Z default-visibility=protected` fails with a link error.

coverage: Remove code related to LLVM 17

2024-10-11T10:44:36+00:00

Use Default visibility for rustc-generated C symbol declarations

2024-10-10T21:43:27+00:00

Non-default visibilities should only be used for definitions, not declarations, otherwise linking can fail. Co-authored-by: Collin Baker

Rollup merge of #130741 - mrkajetanp:detect-b16b16, r=Amanieu

2024-10-10T20:00:48+00:00

rustc_target: Add sme-b16b16 as an explicit aarch64 target feature LLVM 20 split out what used to be called b16b16 and correspond to aarch64 FEAT_SVE_B16B16 into sve-b16b16 and sme-b16b16. Add sme-b16b16 as an explicit feature and update the codegen accordingly. Resolves https://github.com/rust-lang/rust/pull/129894.