rust/compiler/rustc_codegen_ssa/src/back/write.rs, branch 1.76.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.76.02024-01-12T10:27:00+00:00Revert "Auto merge of #113923 - DianQK:restore-no-builtins-lto, r=pnkfelix"2024-01-12T10:27:00+00:00DianQKdianqk@dianqk.net2024-01-12T10:27:00+00:00urn:sha1:251322ea3dedb68aa96c8e830d1dbddc07229912
This reverts commit 8c2b57721728233e074db69d93517614de338055, reversing
changes made to 9cf18e98f82d85fa41141391d54485b8747da46f.
Rename many `DiagCtxt` and `EarlyDiagCtxt` locals.2023-12-18T05:06:22+00:00Nicholas Nethercoten.nethercote@gmail.com2023-12-18T00:15:13+00:00urn:sha1:f6aa418c9f616ae898d01082f8fe324927295d9cRename `CodegenContext::create_diag_handler` as `CodegenContext::create_dcx`.2023-12-18T05:06:21+00:00Nicholas Nethercoten.nethercote@gmail.com2023-12-17T21:43:59+00:00urn:sha1:7c656bc05bdb39884bdc5e87b2ed870233289591Rename `Session::span_diagnostic` as `Session::dcx`.2023-12-18T05:06:21+00:00Nicholas Nethercoten.nethercote@gmail.com2023-12-17T19:21:26+00:00urn:sha1:09af8a667c0fa456bbe62fa462f4b0f42f2845ecRename `Handler` as `DiagCtxt`.2023-12-18T05:06:19+00:00Nicholas Nethercoten.nethercote@gmail.com2023-12-17T10:48:57+00:00urn:sha1:cde19c016e4608288a02f5bdec0b5330d474c26fSplit `Handler::emit_diagnostic` in two.2023-12-14T23:13:12+00:00Nicholas Nethercoten.nethercote@gmail.com2023-12-14T03:13:35+00:00urn:sha1:9a7841251115c79fe7e1c12e2e5d637e19ad940a
Currently, `emit_diagnostic` takes `&mut self`.
This commit changes it so `emit_diagnostic` takes `self` and the new
`emit_diagnostic_without_consuming` function takes `&mut self`.
I find the distinction useful. The former case is much more common, and
avoids a bunch of `mut` and `&mut` occurrences. We can also restrict the
latter with `pub(crate)` which is nice.
Auto merge of #118470 - nnethercote:cleanup-error-handlers, r=compiler-errors2023-12-02T02:48:34+00:00borsbors@rust-lang.org2023-12-02T02:48:34+00:00urn:sha1:2da59b867621eab2c8acb2d14223ddb57cbd86e9
Cleanup error handlers
Mostly by making function naming more consistent. More to do after this, but this is enough for one PR.
r? compiler-errors
Rename `*note_without_error` as `*note`.2023-12-01T21:58:25+00:00Nicholas Nethercoten.nethercote@gmail.com2023-11-30T03:01:35+00:00urn:sha1:57d6f840b9f6d586b7d2ee2549fbfec4e1088dc1
Because the variant name in `Level` is `Note`, and the `without_error`
suffix is omitted in similar cases like `struct_allow` and
`struct_help`.
Auto merge of #113923 - DianQK:restore-no-builtins-lto, r=pnkfelix2023-12-01T21:45:18+00:00borsbors@rust-lang.org2023-12-01T21:45:18+00:00urn:sha1:8c2b57721728233e074db69d93517614de338055
Restore `#![no_builtins]` crates participation in LTO.
After #113716, we can make `#![no_builtins]` crates participate in LTO again.
`#![no_builtins]` with LTO does not result in undefined references to the error. I believe this type of issue won't happen again.
Fixes #72140. Fixes #112245. Fixes #110606. Fixes #105734. Fixes #96486. Fixes #108853. Fixes #108893. Fixes #78744. Fixes #91158. Fixes https://github.com/rust-lang/cargo/issues/10118. Fixes https://github.com/rust-lang/compiler-builtins/issues/347.
The `nightly-2023-07-20` version does not always reproduce problems due to changes in compiler-builtins, core, and user code. That's why this issue recurs and disappears.
Some issues were not tested due to the difficulty of reproducing them.
r? pnkfelix
cc `@bjorn3` `@japaric` `@alexcrichton` `@Amanieu`
Fix `clippy::needless_borrow` in the compiler2023-11-21T19:13:40+00:00Nilstrieb48135649+Nilstrieb@users.noreply.github.com2023-11-21T19:07:32+00:00urn:sha1:21a870515b18e5b2b90435d0f1a6d3089b5217ae
`x clippy compiler -Aclippy::all -Wclippy::needless_borrow --fix`.
Then I had to remove a few unnecessary parens and muts that were exposed
now.