rust/compiler/rustc_codegen_ssa/src/debuginfo, branch 1.54.0

Respond to review feedback

2021-06-02T14:23:12+00:00

Change the type name from `_enum<..>` to `enum$<..>`

2021-06-02T14:23:12+00:00

This makes the type name inline with the proposed standard in #85269.

Generate better debuginfo for niche-layout enums

2021-06-02T14:23:10+00:00

Previously, we would generate a single struct with the layout of the dataful variant plus an extra field whose name contained the value of the niche (this would only really work for things like `Option<&_>` where we can determine that the `None` case maps to `0` but for enums that have multiple tag only variants, this doesn't work). Now, we generate a union of two structs, one which is the layout of the dataful variant and one which just has a way of reading the discriminant. We also generate an enum which maps the discriminant value to the tag only variants. We also encode information about the range of values which correspond to the dataful variant in the type name and then use natvis to determine which union field we should display to the user. As a result of this change, all niche-layout enums render correctly in WinDbg and Visual Studio!

Generate better debuginfo for directly tagged enums

2021-06-02T14:23:09+00:00

Stop adding '*' at the end of type names for Ref and Slice when computing debug info for MSVC debuggers

2020-11-30T22:31:34+00:00

compiler: fold by value

2020-11-16T21:34:57+00:00

Collapse all uses of `target.options.foo` into `target.foo`

2020-11-08T14:29:13+00:00

with an eye on merging `TargetOptions` into `Target`. `TargetOptions` as a separate structure is mostly an implementation detail of `Target` construction, all its fields logically belong to `Target` and available from `Target` through `Deref` impls.

Replace target.target with target and target.ptr_width with target.pointer_width

2020-10-15T10:02:24+00:00

Preparation for a subsequent change that replaces rustc_target::config::Config with its wrapped Target. On its own, this commit breaks the build. I don't like making build-breaking commits, but in this instance I believe that it makes review easier, as the "real" changes of this PR can be seen much more easily. Result of running: find compiler/ -type f -exec sed -i -e 's/target\.target$[)\.,; ]$/target\1/g' {} \; find compiler/ -type f -exec sed -i -e 's/target\.target$/target/g' {} \; find compiler/ -type f -exec sed -i -e 's/target.ptr_width/target.pointer_width/g' {} \; ./x.py fmt

Simplify some match statements on `DefPathDataName'

2020-09-25T21:46:15+00:00

Rename `DefPathData::get_name()` to `DefPathData::name()`

2020-09-25T21:46:15+00:00