https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.59.0 2022-01-07T17:36:09+00:00 2022-01-07T17:36:09+00:00 Wesley Wiser wesleywiser@microsoft.com 2021-12-28T21:57:18+00:00 urn:sha1:836addcbc4fa825e07c78c6feb7f6a0b776ed41a If the target we're generating code for is msvc, then we do two main things differently: we generate type names in a C++ style instead of a Rust style and we generate debuginfo for enums differently. I've refactored the code so that there is one function (`cpp_like_debuginfo`) which determines if we should use the C++ style of naming types and other debuginfo generation or the regular Rust one. 2021-12-19T09:31:37+00:00 bors bors@rust-lang.org 2021-12-19T09:31:37+00:00 urn:sha1:a41a6925badac7508d7a72cc1fc20f43dc6ad75e Remove `SymbolStr` This was originally proposed in https://github.com/rust-lang/rust/pull/74554#discussion_r466203544. As well as removing the icky `SymbolStr` type, it allows the removal of a lot of `&` and `*` occurrences. Best reviewed one commit at a time. r? `@oli-obk` 2021-12-15T06:32:14+00:00 Nicholas Nethercote n.nethercote@gmail.com 2021-12-15T03:39:23+00:00 urn:sha1:056d48a2c97860b2cce936f310331e606076fa01 2021-12-15T05:41:41+00:00 LegionMammal978 mattlloydhouse@gmail.com 2021-12-14T02:52:35+00:00 urn:sha1:eaf39cbd9e37e705664dcf0e1ca1042913cf521a See #91867 for more information. 2021-11-06T15:13:14+00:00 Matthias Krüger matthias.krueger@famsik.de 2021-11-06T00:31:32+00:00 urn:sha1:0a5640b55f4a34a1f96859663449b0cabfb08c87 2021-10-19T11:57:35+00:00 Michael Woerister michaelwoerister@posteo 2021-10-19T09:46:51+00:00 urn:sha1:bf39d86e0f34c439306f9dff9d01ca15792b5fd5 2021-10-11T04:31:47+00:00 bors bors@rust-lang.org 2021-10-11T04:31:47+00:00 urn:sha1:9a757817c352801de8b0593728f8aee21e23cd53 Create more accurate debuginfo for vtables. Before this PR all vtables would have the same name (`"vtable"`) in debuginfo. Now they get an unambiguous name that identifies the implementing type and the trait that is being implemented. This is only one of several possible improvements: - This PR describes vtables as arrays of `*const u8` pointers. It would nice to describe them as structs where function pointer is represented by a field with a name indicative of the method it maps to. However, this requires coming up with a naming scheme that avoids clashes between methods with the same name (which is possible if the vtable contains multiple traits). - The PR does not update the debuginfo we generate for the vtable-pointer field in a fat `dyn` pointer. Right now there does not seem to be an easy way of getting ahold of a vtable-layout without also knowing the concrete self-type of a trait object. r? `@wesleywiser` 2021-10-08T08:33:47+00:00 Michael Woerister michaelwoerister@posteo 2021-10-06T12:26:50+00:00 urn:sha1:61c5a6d644e9e5c1995c33a2b07ab251702848ac Before this commit all vtables would have the same name "vtable" in debuginfo. Now they get a name that identifies the implementing type and the trait that is being implemented. 2021-10-03T14:08:54+00:00 Camille GILLOT gillot.camille@gmail.com 2020-11-14T15:48:54+00:00 urn:sha1:02025d86ac2294078f876015da59d56efe7bf59e 2021-09-09T08:41:19+00:00 Andreas Liljeqvist bonega@gmail.com 2021-08-29T09:06:55+00:00 urn:sha1:5b2f757dae374e22a7733f90af482f405bd426e9 fix fix Remove more refs and clones fix more fix