https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.77.1 2024-01-30T07:46:06+00:00 2024-01-30T07:46:06+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-01-30T04:27:16+00:00 urn:sha1:5350edb9e8f4e194a2cad9a41b81d97a8ed52fab Because it's almost always static. This makes `impl IntoDiagnosticArg for DiagnosticArgValue` trivial, which is nice. There are a few diagnostics constructed in `compiler/rustc_mir_build/src/check_unsafety.rs` and `compiler/rustc_mir_transform/src/errors.rs` that now need symbols converted to `String` with `to_string` instead of `&str` with `as_str`, but that' no big deal, and worth it for the simplifications elsewhere. 2024-01-28T20:41:41+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-01-13T23:57:07+00:00 urn:sha1:5d9dfbd08f38c2a9bc71d39de8f5c7776afe0f9e Error codes are integers, but `String` is used everywhere to represent them. Gross! This commit introduces `ErrCode`, an integral newtype for error codes, replacing `String`. It also introduces a constant for every error code, e.g. `E0123`, and removes the `error_code!` macro. The constants are imported wherever used with `use rustc_errors::codes::*`. With the old code, we have three different ways to specify an error code at a use point: ``` error_code!(E0123) // macro call struct_span_code_err!(dcx, span, E0123, "msg"); // bare ident arg to macro call \#[diag(name, code = "E0123")] // string struct Diag; ``` With the new code, they all use the `E0123` constant. ``` E0123 // constant struct_span_code_err!(dcx, span, E0123, "msg"); // constant \#[diag(name, code = E0123)] // constant struct Diag; ``` The commit also changes the structure of the error code definitions: - `rustc_error_codes` now just defines a higher-order macro listing the used error codes and nothing else. - Because that's now the only thing in the `rustc_error_codes` crate, I moved it into the `lib.rs` file and removed the `error_codes.rs` file. - `rustc_errors` uses that macro to define everything, e.g. the error code constants and the `DIAGNOSTIC_TABLES`. This is in its new `codes.rs` file. 2024-01-09T20:40:00+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-01-08T22:08:49+00:00 urn:sha1:ed76b0b882d0acff9295bcd76c2b119cf83e7219 In #119606 I added them and used a `_mv` suffix, but that wasn't great. A `with_` prefix has three different existing uses. - Constructors, e.g. `Vec::with_capacity`. - Wrappers that provide an environment to execute some code, e.g. `with_session_globals`. - Consuming chaining methods, e.g. `Span::with_{lo,hi,ctxt}`. The third case is exactly what we want, so this commit changes `DiagnosticBuilder::foo_mv` to `DiagnosticBuilder::with_foo`. Thanks to @compiler-errors for the suggestion. 2024-01-08T04:43:07+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-01-03T05:00:29+00:00 urn:sha1:589591efde6c54baa8b7932ec3be6f45dc9d781f To avoid the use of a mutable local variable, and because it reads more nicely. 2024-01-03T08:40:20+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-12-23T22:08:41+00:00 urn:sha1:505c1371d070ba6c9e15db7d331f2d6a2b167b68 `Diagnostic` has 40 methods that return `&mut Self` and could be considered setters. Four of them have a `set_` prefix. This doesn't seem necessary for a type that implements the builder pattern. This commit removes the `set_` prefixes on those four methods. 2023-12-18T22:19:25+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-12-18T03:12:39+00:00 urn:sha1:e7724a2e319f112ee6a97999976d8225b009456e And make all hand-written `IntoDiagnostic` impls generic, by using `DiagnosticBuilder::new(dcx, level, ...)` instead of e.g. `dcx.struct_err(...)`. This means the `create_*` functions are the source of the error level. This change will let us remove `struct_diagnostic`. Note: `#[rustc_lint_diagnostics]` is added to `DiagnosticBuilder::new`, it's necessary to pass diagnostics tests now that it's used in `into_diagnostic` functions. 2023-12-18T05:06:22+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-12-17T23:15:45+00:00 urn:sha1:f422dca3ae8b8a8c9a99b8e6ec0899e08dc072c3 2023-12-18T05:06:19+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-12-17T10:48:57+00:00 urn:sha1:cde19c016e4608288a02f5bdec0b5330d474c26f 2023-10-09T18:39:41+00:00 bjorn3 17426603+bjorn3@users.noreply.github.com 2023-09-19T11:23:35+00:00 urn:sha1:e9fa2ca6add1db7f77c90bdc06210be694ed2571 This removes a bit of global mutable state 2023-10-08T07:05:25+00:00 Vadim Petrochenkov vadim.petrochenkov@gmail.com 2023-10-07T10:57:29+00:00 urn:sha1:b563595c6e6002ab582e2eb4ebd2a19baa8a1e34 It is subsumed by `-Clinker-flavor=*-lld-cc -Clink-self-contained=+linker` options now