https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.84.0 2024-10-29T21:56:00+00:00 2024-10-29T21:56:00+00:00 Jubilee Young workingjubilee@gmail.com 2024-10-29T20:37:26+00:00 urn:sha1:7086dd83cca1cf694c7bd171efbf262fa8ffb4aa The initial naming of "Abi" was an awful mistake, conveying wrong ideas about how psABIs worked and even more about what the enum meant. It was only meant to represent the way the value would be described to a codegen backend as it was lowered to that intermediate representation. It was never meant to mean anything about the actual psABI handling! The conflation is because LLVM typically will associate a certain form with a certain ABI, but even that does not hold when the special cases that actually exist arise, plus the IR annotations that modify the ABI. Reframe `rustc_abi::Abi` as the `BackendRepr` of the type, and rename `BackendRepr::Aggregate` as `BackendRepr::Memory`. Unfortunately, due to the persistent misunderstandings, this too is now incorrect: - Scattered ABI-relevant code is entangled with BackendRepr - We do not always pre-compute a correct BackendRepr that reflects how we "actually" want this value to be handled, so we leave the backend interface to also inject various special-cases here - In some cases `BackendRepr::Memory` is a "real" aggregate, but in others it is in fact using memory, and in some cases it is a scalar! Our rustc-to-backend lowering code handles this sort of thing right now. That will eventually be addressed by lifting duplicated lowering code to either rustc_codegen_ssa or rustc_target as appropriate. 2024-10-09T01:24:56+00:00 Jubilee Young workingjubilee@gmail.com 2024-10-09T00:27:32+00:00 urn:sha1:839cf1c1a4f60575f9000b9f6d5676ec1efbe3e8 2024-10-04T12:06:48+00:00 Urgau urgau@numericable.fr 2024-10-03T13:05:23+00:00 urn:sha1:018ba0528fa5d22712397e520351295f8582a525 2024-09-22T23:11:29+00:00 Michael Goulet michael@errs.io 2024-09-22T23:05:04+00:00 urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1f 2024-09-18T15:49:43+00:00 Matthias Krüger matthias.krueger@famsik.de 2024-09-18T15:49:43+00:00 urn:sha1:21313d7947d435217a916c0d71999a077b90c979 Cleanup codegen traits The traits governing codegen are quite complicated and hard to follow. This PR cleans them up a bit. r? `@bjorn3` 2024-09-17T06:24:35+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-09-10T23:59:50+00:00 urn:sha1:cd3da000c0ea2e1ce77a18587a7acdb01bf7fd23 Reflow overly long comments, plus some minor whitespace improvements. 2024-09-17T06:24:33+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-09-05T05:16:55+00:00 urn:sha1:bdacdfe95f17188f5b047e0330e3e47f993a2016 This makes it much clearer which things are used outside the crate. 2024-09-17T00:24:43+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-09-17T00:15:26+00:00 urn:sha1:a8d22eb39eafcc19d4c3db4f24582d869c8fdef2 Supertraits of `BuilderMethods` are all called `XyzBuilderMethods`. Supertraits of `CodegenMethods` are all called `XyzMethods`. This commit changes the latter to `XyzCodegenMethods`, for consistency. 2024-09-17T00:24:43+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-09-16T10:17:34+00:00 urn:sha1:540fcc617a7d0ab408e81e5668cfa3971233353d Specifically, put them where they are genuinely required, i.e. the outermost place they can be. 2024-08-12T15:09:19+00:00 Guillaume Gomez guillaume1.gomez@gmail.com 2024-08-12T15:09:19+00:00 urn:sha1:7c6dca90509fe94e775bfd5d2c7132fb210f57b4 Use `assert_matches` around the compiler more It's a useful assertion, especially since it actually prints out the LHS.