https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=beta 2025-09-17T20:33:41+00:00 2025-09-17T20:33:41+00:00 Aleksey Kliger alklig@microsoft.com 2025-09-17T20:33:41+00:00 urn:sha1:6347e7f7e00b7ea0d07748443bba31d52ac45626 This reverts commit 095fa86a3ba30f4198c88ef300354391d3ab97e1. 2025-09-13T22:55:17+00:00 Jacob Pratt jacob@jhpratt.dev 2025-09-13T22:55:17+00:00 urn:sha1:141cb38f15e67a273e5bcbfb96d4f8bec2ac47c7 tidy: check that error messages don't start with a capitalized letter 2025-09-13T13:59:48+00:00 bors bors@rust-lang.org 2025-09-13T13:59:48+00:00 urn:sha1:637b50be01093962ac6f4432d6881ab41d6d90b4 Make `AssocItem` aware of its impl kind The general goal is to have fewer query dependencies by making `AssocItem` aware of its parent impl kind (inherent vs. trait) without having to query the parent def_kind. See individual commits. 2025-09-12T20:10:30+00:00 Cameron Steffen cam.steffen94@gmail.com 2025-08-15T21:12:35+00:00 urn:sha1:16c218c57ff83c82ba58753c3a67f697e260adc1 2025-09-12T18:53:28+00:00 Noratrieb 48135649+Noratrieb@users.noreply.github.com 2025-07-26T10:39:31+00:00 urn:sha1:f157ce994ea45e9faea9eff89c5f8b3d4ea77b6e This schema is helpful for people writing custom target spec JSON. It can provide autocomplete in the editor, and also serves as documentation when there are documentation comments on the structs, as `schemars` will put them in the schema. 2025-09-12T10:02:10+00:00 Stuart Cook Zalathar@users.noreply.github.com 2025-09-12T10:02:10+00:00 urn:sha1:48d684111e462b1ff600728b9a816520a4f3276a match clang's `va_arg` assembly on arm targets tracking issue: https://github.com/rust-lang/rust/issues/44930 For this example ```rust #![feature(c_variadic)] #[unsafe(no_mangle)] unsafe extern "C" fn variadic(a: f64, mut args: ...) -> f64 { let b = args.arg::<f64>(); let c = args.arg::<f64>(); a + b + c } ``` We currently generate (via llvm): ```asm variadic: sub sp, sp, #12 stmib sp, {r2, r3} vmov d0, r0, r1 add r0, sp, #4 vldr d1, [sp, #4] add r0, r0, #15 bic r0, r0, #7 vadd.f64 d0, d0, d1 add r1, r0, #8 str r1, [sp] vldr d1, [r0] vadd.f64 d0, d0, d1 vmov r0, r1, d0 add sp, sp, #12 bx lr ``` LLVM is not doing a good job. In fact, it's well-known that LLVM's implementation of `va_arg` is kind of bad, and we implement it ourselves (based on clang) for many targets already. For arm, our own `emit_ptr_va_arg` saves 3 instructions. Next, it turns out it's important for LLVM to explicitly start and end the lifetime of the `va_list`. In https://github.com/rust-lang/rust/pull/146059 I already end the lifetime, but when looking at this again, I noticed that it is important to also start it, see https://godbolt.org/z/EGqvKTTsK: failing to explicitly start the lifetime uses an extra register. So, the combination of `emit_ptr_va_arg` with starting/ending the lifetime makes rustc emit exactly the instructions that clang generates:: ```asm variadic: sub sp, sp, #12 stmib sp, {r2, r3} vmov d16, r0, r1 vldr d17, [sp, #4] vadd.f64 d16, d16, d17 vldr d17, [sp, #12] vadd.f64 d16, d16, d17 vmov r0, r1, d16 add sp, sp, #12 bx lr ``` The arguments to `emit_ptr_va_arg` are based on [the clang implementation](https://github.com/llvm/llvm-project/blob/03dc2a41f3d9a500e47b513de5c5008c06860d65/clang/lib/CodeGen/Targets/ARM.cpp#L798-L844). r? ``@workingjubilee`` (I can re-roll if your queue is too full, but you do seem like the right person here) try-job: armhf-gnu 2025-09-10T19:45:07+00:00 Sasha Pourcelot sasha.pourcelot@protonmail.com 2025-09-03T13:23:07+00:00 urn:sha1:b152974301cc24b9003674935e7492fb46d6f299 2025-09-09T03:56:41+00:00 bors bors@rust-lang.org 2025-09-09T03:56:41+00:00 urn:sha1:fefce3cecd63cebf2d7c9aa3dd90a84379fcfa1a compiler: Add Windows resources to rustc-main and rustc_driver Adds Windows resources with the rust version information to rustc-main.exe and rustc_driver.dll Invokes `rc.exe` directly, rather than using one of the crates from the ecosystem to avoid adding dependencies. A new internal `rustc_windows_rc` crate has the common build script machinery for locating `rc.exe` and constructing the resource script 2025-09-07T18:02:27+00:00 Matthias Krüger 476013+matthiaskrgr@users.noreply.github.com 2025-09-07T18:02:27+00:00 urn:sha1:92bad93f06dc25a5370bbd85cf7e43160a03d80b Misc LTO cleanups Follow up to https://github.com/rust-lang/rust/pull/145955. * Remove want_summary argument from `prepare_thin`. Since https://github.com/rust-lang/rust/pull/133250 ThinLTO summary writing is instead done by `llvm_optimize`. * Two minor cleanups 2025-09-07T06:18:59+00:00 Matthias Krüger 476013+matthiaskrgr@users.noreply.github.com 2025-09-07T06:18:59+00:00 urn:sha1:cb8b5fa4e2a68460ffbf7a733cd2851fa13ba6a9 Use `Itertools::all_equal_value()` where applicable Just a small cleanup. We already have `itertools` as a dep in these crates, so might as well use another of its features. Makes the code simpler IMHO :)