https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.86.0 2025-01-07T12:30:02+00:00 2025-01-07T12:30:02+00:00 Josh Triplett josh@joshtriplett.org 2025-01-07T12:12:07+00:00 urn:sha1:bb6bbfa13f97e6ef30ecd63c835c99cf7762bd6e This renames variables named `str` to other names, to make sure `str` always refers to a type. It's confusing to read code where `str` (or another standard type name) is used as an identifier. It also produces misleading syntax highlighting. 2024-12-14T13:07:57+00:00 Matthias Krüger matthias.krueger@famsik.de 2024-12-14T13:07:57+00:00 urn:sha1:fffdb1bc013a0fbcd2d3a16e4aec1357082f637e Make some types and methods related to Polonius + Miri public We have a tool, [Aquascope](https://github.com/cognitive-engineering-lab/aquascope/), which uses Polonius and Miri to visualize the compile-time and run-time semantics of a Rust program. Changes in the last few months to both APIs have hidden away details we depend upon. This PR re-exposes some of those details, specifically: **Polonius:** - `BorrowSet` and `BorrowData` are added to `rustc_borrowck::consumers`, and their fields are made `pub` instead of `pub(crate)`. We need this to interpret the `BorrowIndex`es generated by Polonius. - `BorrowSet::build` is now `pub`. We need this because the borrowck API doesn't provide access to the `BorrowSet` constructed during checking. - `PoloniusRegionVid` is added to `rustc_borrowck::consumers`. We need this because it's also contained in the Polonius facts. **Miri:** - `InterpCx::local_to_op` is now a special case of `local_at_frame_to_op`, which allows querying locals in any frame. We need this because we walk the whole stack at each step to collect the state of memory. - `InterpCx::layout_of_local` is now `pub`. We need this because we need to know the layout of every local at each step. If these changes go against some design goal for keeping certain types private, please let me know so we can hash out a better solution. Additionally, if there's a better way to document that it's important that certain types stay public, also let me know. For example, `BorrowSet` was previously public but was hidden in 6676cec, breaking our build. cc ```@RalfJung``` ```@nnethercote``` ```@gavinleroy``` 2024-12-12T20:34:43+00:00 Will Crichton wcrichto@cs.stanford.edu 2024-12-12T20:34:43+00:00 urn:sha1:4d5d4700f3c7fa5151560d27f389c15a7a3047a0 2024-12-12T01:28:49+00:00 Will Crichton wcrichto@cs.stanford.edu 2024-12-12T00:40:54+00:00 urn:sha1:eb10db0a76fdacdbe6747431aea90f17ce4ec7c1 2024-12-09T08:27:18+00:00 Ralf Jung post@ralfj.de 2024-12-09T08:27:18+00:00 urn:sha1:0bb8615ed9e68eea49721238a36db98487f078d6 2024-11-18T09:38:56+00:00 lcnr rust@lcnr.de 2024-11-15T12:53:31+00:00 urn:sha1:9cba14b95bb07a5b31ed1aac2bf4eadd248232da the behavior of the type system not only depends on the current assumptions, but also the currentnphase of the compiler. This is mostly necessary as we need to decide whether and how to reveal opaque types. We track this via the `TypingMode`. 2024-10-31T13:55:53+00:00 lcnr rust@lcnr.de 2024-10-31T11:41:50+00:00 urn:sha1:2cde638ac0b8f2fd1b7ad29606a1a406b276482a 2024-10-29T21:56:00+00:00 Jubilee Young workingjubilee@gmail.com 2024-10-29T20:37:26+00:00 urn:sha1:7086dd83cca1cf694c7bd171efbf262fa8ffb4aa The initial naming of "Abi" was an awful mistake, conveying wrong ideas about how psABIs worked and even more about what the enum meant. It was only meant to represent the way the value would be described to a codegen backend as it was lowered to that intermediate representation. It was never meant to mean anything about the actual psABI handling! The conflation is because LLVM typically will associate a certain form with a certain ABI, but even that does not hold when the special cases that actually exist arise, plus the IR annotations that modify the ABI. Reframe `rustc_abi::Abi` as the `BackendRepr` of the type, and rename `BackendRepr::Aggregate` as `BackendRepr::Memory`. Unfortunately, due to the persistent misunderstandings, this too is now incorrect: - Scattered ABI-relevant code is entangled with BackendRepr - We do not always pre-compute a correct BackendRepr that reflects how we "actually" want this value to be handled, so we leave the backend interface to also inject various special-cases here - In some cases `BackendRepr::Memory` is a "real" aggregate, but in others it is in fact using memory, and in some cases it is a scalar! Our rustc-to-backend lowering code handles this sort of thing right now. That will eventually be addressed by lifting duplicated lowering code to either rustc_codegen_ssa or rustc_target as appropriate. 2024-10-09T01:24:56+00:00 Jubilee Young workingjubilee@gmail.com 2024-10-08T23:59:24+00:00 urn:sha1:9d95c8bd1606b914a0fc1ae9ba21efb3490491ce 2024-10-03T06:26:25+00:00 Ralf Jung post@ralfj.de 2024-09-30T15:49:51+00:00 urn:sha1:a8f9a32650122dd7c54ad20d1230bcb62c6506ff