https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=perf-tmp 2024-09-02T05:42:38+00:00 2024-09-02T05:42:38+00:00 Alexander Cyon alex.cyon@gmail.com 2024-09-02T05:42:38+00:00 urn:sha1:ac69544a175d692dd623fb854261ca64b1b9b802 2024-07-28T22:26:52+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-07-28T22:13:50+00:00 urn:sha1:84ac80f1921afc243d71fd0caaa4f2838c294102 The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options. 2024-06-19T23:23:18+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-06-19T19:02:12+00:00 urn:sha1:09006d6a88019b80f7158f1a5f754a358751d7f1 This makes their intent and expected location clearer. We see some examples where these comments were not clearly separate from `use` declarations, which made it hard to understand what the comment is describing. 2024-04-22T14:50:07+00:00 Ben Kimock kimockb@gmail.com 2024-04-03T18:09:21+00:00 urn:sha1:6ee3713b08a3612de836a2dab527e5a644517aa1 2023-08-01T18:10:17+00:00 Taras Tsugrii taras.tsugriy@gmail.com 2023-08-01T18:10:17+00:00 urn:sha1:64dfd1090d20d112038fecad7fcd2b988e372442 Since all output characters taken from `BASE_64` are valid UTF8 chars there is no need to waste cycles on validation. Even though it's obviously a perf win, I've also used a [benchmark](https://gist.github.com/ttsugriy/e1e63c07927d8f31e71695a9c617bbf3) on M1 MacBook Air with following results: ``` Running benches/base_n_benchmark.rs (target/release/deps/base_n_benchmark-825fe5895b5c2693) push_str/old time: [14.670 µs 14.852 µs 15.074 µs] Performance has regressed. Found 11 outliers among 100 measurements (11.00%) 4 (4.00%) high mild 7 (7.00%) high severe push_str/new time: [12.573 µs 12.674 µs 12.801 µs] Performance has regressed. Found 11 outliers among 100 measurements (11.00%) 7 (7.00%) high mild 4 (4.00%) high severe ``` 2023-07-31T19:40:11+00:00 Taras Tsugrii taras.tsugriy@gmail.com 2023-07-31T19:40:11+00:00 urn:sha1:b84942a0fe11c06a94cfe46ee787084e80c51fb9 This minor change removes the need to reverse resulting digits. Since reverse is O(|digit_num|) but bounded by 128, it's unlikely to be a noticeable in practice. At the same time, this code is also a 1 line shorter, so combined with tiny perf win, why not? I ran https://gist.github.com/ttsugriy/ed14860ef597ab315d4129d5f8adb191 on M1 macbook air and got a small improvement ``` Running benches/base_n_benchmark.rs (target/release/deps/base_n_benchmark-825fe5895b5c2693) push_str/old time: [14.180 µs 14.313 µs 14.462 µs] Performance has improved. Found 5 outliers among 100 measurements (5.00%) 4 (4.00%) high mild 1 (1.00%) high severe push_str/new time: [13.741 µs 13.839 µs 13.973 µs] Performance has improved. Found 8 outliers among 100 measurements (8.00%) 3 (3.00%) high mild 5 (5.00%) high severe ``` 2022-12-12T18:49:53+00:00 Matthias Krüger matthias.krueger@famsik.de 2022-12-12T18:49:53+00:00 urn:sha1:2ea368e53c755fb13d3ad5cd59370a3f7ad4e8c0 2021-10-15T09:28:23+00:00 Matthias Krüger matthias.krueger@famsik.de 2021-10-15T09:24:20+00:00 urn:sha1:44570143989cdd529aff488b8fa5534c4802fbce The PR had some unforseen perf regressions that are not as easy to find. Revert the PR for now. This reverts commit 6ae8912a3e7d2c4c775024f58a7ba4b1aedc4073, reversing changes made to 86d6d2b7389fe1b339402c1798edae8b695fc9ef. 2021-10-10T13:38:19+00:00 Clemens Wasser clemens.wasser@gmail.com 2021-10-09T18:44:22+00:00 urn:sha1:71dd0b928b8b175b69e56fc58e5878b73f090718 2020-08-30T15:45:07+00:00 mark markm@cs.wisc.edu 2020-08-28T03:58:48+00:00 urn:sha1:9e5f7d5631b8f4009ac1c693e585d4b7108d4275