rust/compiler/rustc_data_structures/src/memmap.rs, branch tryhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try2025-02-05T13:52:22+00:00Couple of changes to run rustc in miri2025-02-05T13:52:22+00:00bjorn317426603+bjorn3@users.noreply.github.com2025-02-05T13:52:22+00:00urn:sha1:e27495c015c3df7f82cc15c73968f836c10cc9e9Issue 122262: MAP_PRIVATE for more reliability on virtualised filesystems.2024-03-15T22:31:07+00:00Guillaume Yziquelguillaume@vizyon.ai2024-03-10T20:00:42+00:00urn:sha1:3fc5ed8067f98e2cae8c259a2e367024c59a3ad3
Adding support of quirky filesystems occuring in virtualised settings not
having full POSIX support for memory mapped files. Example: current virtiofs
with cache disabled, occuring in Incus/LXD or Kata Containers. Has been
hitting various virtualised filesystems since 2016, depending on their levels
of maturity at the time. The situation will perhaps improve when virtiofs DAX
support patches will have made it into the qemu mainline.
On a reliability level, using the MAP_PRIVATE sycall flag instead of the
MAP_SHARED syscall flag for the mmap() system call does have some undefined
behaviour when the caller update the memory mapping of the mmap()ed file, but
MAP_SHARED does allow not only the calling process but other processes to
modify the memory mapping. Thus, in the current context, using MAP_PRIVATE
copy-on-write is marginally more reliable than MAP_SHARED.
This discussion of reliability is orthogonal to the type system enforced safety
policy of rust, which does not claim to handle memory modification of memory
mapped files triggered through the operating system and not the running rust
process.
elaborate a bit on the (lack of) safety in 'Mmap::map'2023-08-19T10:50:26+00:00Ralf Jungpost@ralfj.de2023-08-19T10:49:07+00:00urn:sha1:132a2c6cf29649d0b57f3efe9fe72beef8fc7c9e`deny(unsafe_op_in_unsafe_fn)` in `rustc_data_structures`2023-04-19T18:00:48+00:00Maybe Wafflewaffle.lapkin@gmail.com2023-04-19T18:00:48+00:00urn:sha1:f79df7d2a4e224aa35697e5096d0f25fdcf26b2fFix some clippy::complexity2023-04-09T21:22:14+00:00Nilstrieb48135649+Nilstrieb@users.noreply.github.com2023-04-09T21:07:18+00:00urn:sha1:81c320ea7786a2b5a07a165aedacb438ae14fd74Yeet `owning_ref`2023-04-05T13:49:48+00:00Maybe Wafflewaffle.lapkin@gmail.com2023-04-05T13:28:25+00:00urn:sha1:d7056548f9dd51d44d9d29fd0376ac509605076b
Turns out
- `owning_ref` is unsound due to `Box` aliasing stuff
- `rustc` doesn't need 99% of the `owning_ref` API
- `rustc` can use a far simpler abstraction that is `OwnedSlice`
Auto merge of #105218 - matthiaskrgr:rollup-8d3k08n, r=matthiaskrgr2022-12-03T21:25:45+00:00borsbors@rust-lang.org2022-12-03T21:25:45+00:00urn:sha1:b8a52e3a4ba9549edb71836561be13e73a8a50a7
Rollup of 9 pull requests
Successful merges:
- #104199 (Keep track of the start of the argument block of a closure)
- #105050 (Remove useless borrows and derefs)
- #105153 (Create a hacky fail-fast mode that stops tests at the first failure)
- #105164 (Restore `use` suggestion for `dyn` method call requiring `Sized`)
- #105193 (Disable coverage instrumentation for naked functions)
- #105200 (Remove useless filter in unused extern crate check.)
- #105201 (Do not call fn_sig on non-functions.)
- #105208 (Add AmbiguityError for inconsistent resolution for an import)
- #105214 (update Miri)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
Remove useless borrows and derefs2022-12-01T17:34:43+00:00Maybe Wafflewaffle.lapkin@gmail.com2022-11-29T11:01:17+00:00urn:sha1:f2b97a8bfe23cdda293908e3c3e01f2613787168Rewrite LLVM's archive writer in Rust2022-11-26T19:35:32+00:00bjorn3bjorn3@users.noreply.github.com2022-05-28T10:43:51+00:00urn:sha1:be6708428fdf6693188e2c2f10f05d1b1aaa5750
This allows it to be used by other codegen backends
define MmapMut and use it in Decodable impl2022-07-02T13:54:37+00:00Yoshiki Matsudamyskjp@gmail.com2022-05-08T03:36:12+00:00urn:sha1:c57d7788729f32e74966f67eea582ec7ec75a133