https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.72.0 2023-05-18T03:14:45+00:00 2023-05-18T03:14:45+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-05-18T03:14:45+00:00 urn:sha1:9bfb90b1bed203a6df2850173f6fb30464e99645 2023-04-27T17:43:09+00:00 bors bors@rust-lang.org 2023-04-27T17:43:09+00:00 urn:sha1:c14882f74e8feb3f76ae85ed5cd66afaccd1da67 Move the WorkerLocal type from the rustc-rayon fork into rustc_data_structures This PR moves the definition of the `WorkerLocal` type from `rustc-rayon` into `rustc_data_structures`. This is enabled by the introduction of the `Registry` type which allows you to group up threads to be used by `WorkerLocal` which is basically just an array with an per thread index. The `Registry` type mirrors the one in Rayon and each Rayon worker thread is also registered with the new `Registry`. Safety for `WorkerLocal` is ensured by having it keep a reference to the registry and checking on each access that we're still on the group of threads associated with the registry used to construct it. Accessing a `WorkerLocal` is micro-optimized due to it being hot since it's used for most arena allocations. Performance is slightly improved for the parallel compiler: <table><tr><td rowspan="2">Benchmark</td><td colspan="1"><b>Before</b></th><td colspan="2"><b>After</b></th></tr><tr><td align="right">Time</td><td align="right">Time</td><td align="right">%</th></tr><tr><td>🟣 <b>clap</b>:check</td><td align="right">1.9992s</td><td align="right">1.9949s</td><td align="right"> -0.21%</td></tr><tr><td>🟣 <b>hyper</b>:check</td><td align="right">0.2977s</td><td align="right">0.2970s</td><td align="right"> -0.22%</td></tr><tr><td>🟣 <b>regex</b>:check</td><td align="right">1.1335s</td><td align="right">1.1315s</td><td align="right"> -0.18%</td></tr><tr><td>🟣 <b>syn</b>:check</td><td align="right">1.8235s</td><td align="right">1.8171s</td><td align="right"> -0.35%</td></tr><tr><td>🟣 <b>syntex_syntax</b>:check</td><td align="right">6.9047s</td><td align="right">6.8930s</td><td align="right"> -0.17%</td></tr><tr><td>Total</td><td align="right">12.1586s</td><td align="right">12.1336s</td><td align="right"> -0.21%</td></tr><tr><td>Summary</td><td align="right">1.0000s</td><td align="right">0.9977s</td><td align="right"> -0.23%</td></tr></table> cc `@SparrowLii` 2023-04-24T13:53:35+00:00 Maybe Waffle waffle.lapkin@gmail.com 2023-04-19T10:57:17+00:00 urn:sha1:e496fbec922b22d9b506ba55386c482b4bf06378 2023-04-16T03:50:57+00:00 John Kåre Alsaker john.kare.alsaker@gmail.com 2020-10-31T11:01:54+00:00 urn:sha1:64474a40b0273557dbea58ca29af9245cbb4ad87 2023-04-09T21:22:14+00:00 Nilstrieb 48135649+Nilstrieb@users.noreply.github.com 2023-04-09T21:07:18+00:00 urn:sha1:81c320ea7786a2b5a07a165aedacb438ae14fd74 2023-04-04T09:01:44+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2023-03-14T12:30:16+00:00 urn:sha1:a1d20cf7a20eb69b7a48c9897dfd8e9a3e4b6360 2023-04-04T09:01:44+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2023-03-14T12:16:19+00:00 urn:sha1:7edd1d8799aff9d4dfea72e37c500ec8fdb0afb8 2023-04-04T09:01:44+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2023-03-14T12:11:56+00:00 urn:sha1:46996326377b100fa461b49b5be0c91a075f55e5 2023-04-04T09:01:44+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2023-03-14T11:51:00+00:00 urn:sha1:daee746771f12f58f707787e8075d9f89ec0511d 2023-02-21T08:38:24+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2023-02-21T08:37:10+00:00 urn:sha1:decfb4d123651a0673db47542e18ca60d1c501ac