rust/compiler/rustc_data_structures/src, branch 1.68.2https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.68.22023-01-21T14:18:17+00:00Auto merge of #106977 - michaelwoerister:unord_id_collections, r=oli-obk2023-01-21T14:18:17+00:00borsbors@rust-lang.org2023-01-21T14:18:17+00:00urn:sha1:005fc0f00f2d4ceaf523b67a8f9c5665b8ac5baf
Use UnordMap and UnordSet for id collections (DefIdMap, LocalDefIdMap, etc)
This PR changes the `rustc_data_structures::define_id_collections!` macro to use `UnordMap` and `UnordSet` instead of `FxHashMap` and `FxHashSet`. This should account for a large portion of hash-maps being used in places where they can cause trouble.
The changes required are moderate but non-zero:
- In some places the collections are extracted into sorted vecs.
- There are a few instances where for-loops have been changed to extends.
~~Let's see what the performance impact is. With a bit more refactoring, we might be able to get rid of some of the additional sorting -- but the change set is already big enough. Unless there's a performance impact, I'd like to do further changes in subsequent PRs.~~
Performance does not seem to be negatively affected ([perf-run here](https://github.com/rust-lang/rust/pull/106977#issuecomment-1396776699)).
Part of [MCP 533](https://github.com/rust-lang/compiler-team/issues/533).
r? `@ghost`
Auto merge of #106976 - tmiasko:borrowck-lazy-dominators, r=cjgillot2023-01-21T11:02:29+00:00borsbors@rust-lang.org2023-01-21T11:02:29+00:00urn:sha1:21f683935257713eae8549e8b328367006097053
Lazy dominator tree construction in borrowck
Motivated by the observation that sometimes constructed dominator tree was never queried.
Auto merge of #106090 - WaffleLapkin:dereffffffffff, r=Nilstrieb2023-01-20T04:52:28+00:00borsbors@rust-lang.org2023-01-20T04:52:28+00:00urn:sha1:56ee85274e5a3a4dda92f3bf73d1664c74ff9c15
Remove some `ref` patterns from the compiler
Previous PR: https://github.com/rust-lang/rust/pull/105368
r? `@Nilstrieb`
Clean up and document unord collections a bit.2023-01-19T16:37:59+00:00Michael Woeristermichaelwoerister@posteo2023-01-19T16:37:59+00:00urn:sha1:f219771961c94f218d23bfab66aa678c48840fc4Rollup merge of #107037 - tmiasko:rank, r=oli-obk2023-01-19T10:19:36+00:00Guillaume Gomezguillaume1.gomez@gmail.com2023-01-19T10:19:36+00:00urn:sha1:dee88e0fa2a9225fa20222b694523a798d5c4c52
Fix Dominators::rank_partial_cmp to match documentation
The only use site is also updated accordingly and there is no change in end-to-end behaviour.
Allow for more efficient sorting when exporting Unord collections.2023-01-19T09:40:54+00:00Michael Woeristermichaelwoerister@posteo2023-01-18T09:47:31+00:00urn:sha1:72ee14ce3960ca02ba4f4a19b84bf9c27ec6de9dUse UnordMap instead of FxHashMap in define_id_collections!().2023-01-19T09:40:47+00:00Michael Woeristermichaelwoerister@posteo2023-01-17T11:05:01+00:00urn:sha1:c3d25731207e466fc20b00124a5aadd435d3b885Use UnordSet instead of FxHashSet in define_id_collections!().2023-01-19T09:19:07+00:00Michael Woeristermichaelwoerister@posteo2022-12-02T15:27:25+00:00urn:sha1:8a1de57a4aaf4ff13d20fdbc162064f237bb7679Also remove `#![feature(control_flow_enum)]` where possible2023-01-18T18:22:21+00:00Scott McMurrayscottmcm@users.noreply.github.com2023-01-18T18:22:21+00:00urn:sha1:7d57685682778900cb3b8d57605a143d402b8d0cFix Dominators::rank_partial_cmp to match documentation2023-01-18T16:11:43+00:00Tomasz Miąskotomasz.miasko@gmail.com2023-01-18T00:00:00+00:00urn:sha1:b8c5821ad8bd4ae9da7b157d9189e2bc1bfe788e
The only use site is also updated accordingly and there is no change in
end-to-end behaviour.