https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=try 2025-07-07T13:16:42+00:00 2025-07-07T13:16:42+00:00 Jakub Beránek berykubik@gmail.com 2025-07-07T13:16:42+00:00 urn:sha1:37115f1bd612a341f621bc60d09de93b8915d76b 2025-07-04T22:12:10+00:00 Matthias Krüger 476013+matthiaskrgr@users.noreply.github.com 2025-07-04T22:12:10+00:00 urn:sha1:567c51d5841ef30a16aecadc6bd190b2e9f92e5c Remove some unnecessary `unsafe` in VecCache I'm pretty sure, but until perf confirms, r? ghost 2025-07-04T00:42:43+00:00 Scott McMurray scottmcm@users.noreply.github.com 2025-07-04T00:42:43+00:00 urn:sha1:15286f220e54e39dc533e43a492679e957bf332b 2025-07-03T11:29:35+00:00 Jana Dönszelmann jonathan@donsz.nl 2025-07-03T11:29:35+00:00 urn:sha1:f6d37a25a96fd2c20f4349474d81bbb35e2ecba3 setup typos check in CI This allows to check typos in CI, currently for compiler only (to reduce commit size with fixes). With current setup, exclude list is quite short, so it worth trying? Also includes commits with actual typo fixes. MCP: https://github.com/rust-lang/compiler-team/issues/817 typos check currently turned for: * ./compiler * ./library * ./src/bootstrap * ./src/librustdoc After merging, PRs which enables checks for other crates (tools) can be implemented too. Found typos will **not break** other jobs immediately: (tests, building compiler for perf run). Job will be marked as red on completion in ~ 20 secs, so you will not forget to fix it whenever you want, before merging pr. Check typos: `python x.py test tidy --extra-checks=spellcheck` Apply typo fixes: `python x.py test tidy --extra-checks=spellcheck:fix` (in case if there only 1 suggestion of each typo) Current fail in this pr is expected and shows how typo errors emitted. Commit with error will be removed after r+. 2025-07-03T07:51:06+00:00 klensy klensy@users.noreply.github.com 2024-12-07T10:51:08+00:00 urn:sha1:c76d032f0144b650a438ee1efba89c475e0b115b 2025-07-02T11:41:14+00:00 bors bors@rust-lang.org 2025-07-02T11:41:14+00:00 urn:sha1:b94bd12401d26ccf1c3b04ceb4e950b0ff7c8d29 Add new self-profiling event to cheaply aggregate query cache hit counts Self-profile can record various types of things, some of them are not enabled, like query cache hits. Rustc currently records cache hits as "instant" measureme events, which records the thread ID, current timestamp, and constructs an individual event for each such cache hit. This is incredibly expensive, in a small hello world benchmark that just depends on serde, it makes compilation with nightly go from ~3s (with `-Zself-profile`) to ~15s (with `-Zself-profile -Zself-profile-events=default,query-cache-hit`). We'd like to add query cache hits to rustc-perf (https://github.com/rust-lang/rustc-perf/pull/2168), but there we only need the actualy cache hit counts, not the timestamp/thread ID metadata associated with it. This PR adds a new `query-cache-hit-count` event. Instead of generating individual instant events, it simply aggregates cache hit counts per *query invocation* (so a combination of a query and its arguments, if I understand it correctly) using an atomic counter. At the end of the compilation session, these counts are then dumped to the self-profile log using integer events (in a similar fashion as how we record artifact sizes). I suppose that we could dedup the query invocations in rustc directly, but I don't think it's really required. In local experiments with the hello world + serde case, the query invocation records generated ~30 KiB more data in the self-profile, which was ~10% increase in this case. With this PR, the overhead of `-Zself-profile` seems to be the same as before, at least on my machine, so I also enabled query cache hit counts by default when self profiling is enabled. We should also modify `analyzeme`, specifically [this](https://github.com/rust-lang/measureme/blob/master/analyzeme/src/analysis.rs#L139), and make it load the integer events with query cache hit counts. I can do that as a follow-up, it's not required to be done in sync with this PR, and it doesn't require changes in rustc. CC `@cjgillot` r? `@oli-obk` 2025-07-02T08:04:35+00:00 Jakub Beránek berykubik@gmail.com 2025-07-02T08:04:35+00:00 urn:sha1:b49ca021e1569e219265651eb7bd936d5ac21886 2025-07-01T17:55:49+00:00 Josh Stone jistone@redhat.com 2025-06-24T17:05:56+00:00 urn:sha1:e851e3e16e161e624b4108b83889b3fdbd5d44dd 2025-06-26T06:14:34+00:00 Jakub Beránek berykubik@gmail.com 2025-06-26T06:14:05+00:00 urn:sha1:e8fc30ee05496f2b3e57c1a44e33b6480f5140a2 2025-06-25T09:09:58+00:00 Jakub Beránek berykubik@gmail.com 2025-06-25T09:09:58+00:00 urn:sha1:04ff853e13de10052ea03bcdc3c874eafa2deb5d