https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.61.0 2022-02-20T23:58:21+00:00 2022-02-20T23:58:21+00:00 Mark Rousskov mark.simulacrum@gmail.com 2022-02-09T22:05:44+00:00 urn:sha1:60b71f56e73fc139eababa00aa8f1b740cb7d445 This is no longer used by the compiler itself, and removing this support opens the door to massively simplifying the Decodable/Decoder API by dropping the self-describing deserialization support (necessary for JSON). 2022-01-21T23:38:31+00:00 Nicholas Nethercote n.nethercote@gmail.com 2022-01-18T02:22:50+00:00 urn:sha1:416399dc1028545ea0ac6d68fb0b5cc5fa97d393 `Decoder` has two impls: - opaque: this impl is already partly infallible, i.e. in some places it currently panics on failure (e.g. if the input is too short, or on a bad `Result` discriminant), and in some places it returns an error (e.g. on a bad `Option` discriminant). The number of places where either happens is surprisingly small, just because the binary representation has very little redundancy and a lot of input reading can occur even on malformed data. - json: this impl is fully fallible, but it's only used (a) for the `.rlink` file production, and there's a `FIXME` comment suggesting it should change to a binary format, and (b) in a few tests in non-fundamental ways. Indeed #85993 is open to remove it entirely. And the top-level places in the compiler that call into decoding just abort on error anyway. So the fallibility is providing little value, and getting rid of it leads to some non-trivial performance improvements. Much of this commit is pretty boring and mechanical. Some notes about a few interesting parts: - The commit removes `Decoder::{Error,error}`. - `InternIteratorElement::intern_with`: the impl for `T` now has the same optimization for small counts that the impl for `Result<T, E>` has, because it's now much hotter. - Decodable impls for SmallVec, LinkedList, VecDeque now all use `collect`, which is nice; the one for `Vec` uses unsafe code, because that gave better perf on some benchmarks. 2021-07-08T14:16:28+00:00 Guillaume Gomez guillaume1.gomez@gmail.com 2021-05-05T19:31:25+00:00 urn:sha1:a2654fb64c9c9d368063b488693d8da17bc9b4e9 2020-08-30T15:45:07+00:00 mark markm@cs.wisc.edu 2020-08-28T03:58:48+00:00 urn:sha1:9e5f7d5631b8f4009ac1c693e585d4b7108d4275