rust/compiler/rustc_errors/src, branch 1.70.0

Rollup merge of #110072 - joshtriplett:stabilize-is-terminal, r=Mark-Simulacrum

2023-04-13T09:21:00+00:00

Stabilize IsTerminal FCP completed in https://github.com/rust-lang/rust/issues/98070 . closes: https://github.com/rust-lang/rust/issues/98070

Auto merge of #109786 - estebank:tweak-add-line-sugg, r=compiler-errors

2023-04-13T07:02:53+00:00

Tweak output for 'add line' suggestion Closes #108174

Special-case item attributes in the suggestion output

2023-04-12T22:50:10+00:00

Tweak output for 'add line' suggestion

2023-04-12T22:50:10+00:00

Rollup merge of #110135 - compiler-errors:revert-108031, r=davidtwco

2023-04-12T20:04:35+00:00

Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR #108031 per https://github.com/rust-lang/rust/pull/109754#issuecomment-1490452045 Fixes (doesnt close until beta backported) #109746 This reverts commit e3f9db5fc319c6d8eee5d47d216ea6a426070c41. This reverts commit 98b82aedba3f3f581e89df54352914b27f42c6f7. This reverts commit 380fa264132ad481e73cbbf0f3a0feefd99a1d78.

Auto merge of #110092 - clubby789:builtin-macros-translatable, r=compiler-errors

2023-04-11T14:40:54+00:00

Migrate most of `rustc_builtin_macros` to diagnostic impls cc #100717 This is a couple of days work, but I decided to stop for now before the PR becomes too big. There's around 50 unresolved failures when `rustc::untranslatable_diagnostic` is denied, which I'll finish addressing once this PR goes thtough A couple of outputs have changed, but in all instances I think the changes are an improvement/are more consistent with other diagnostics (although I'm happy to revert any which seem worse)

Migrate most of `rustc_builtin_macros` to diagnostic impls

2023-04-10T20:16:53+00:00

Co-authored-by: Joe ST Co-authored-by: Michael Goulet

Stabilize IsTerminal

2023-04-10T08:24:23+00:00

closes: https://github.com/rust-lang/rust/issues/98070

Revert "Don't recover lifetimes/labels containing emojis as character literals"

2023-04-10T06:52:41+00:00

Reverts PR #108031 Fixes (doesnt close until beta backported) #109746 This reverts commit e3f9db5fc319c6d8eee5d47d216ea6a426070c41. This reverts commit 98b82aedba3f3f581e89df54352914b27f42c6f7. This reverts commit 380fa264132ad481e73cbbf0f3a0feefd99a1d78.

Fix some clippy::complexity

2023-04-09T21:22:14+00:00