rust/compiler/rustc_errors/src, branch 1.85.1

Convert some Into impls into From impls

2024-12-31T01:56:33+00:00

Account for removal of multiline span in suggestion

2024-12-26T17:41:43+00:00

When highlighting the removed parts of a suggestion, properly account for spans that cover more than one line. Fix #134485.

Rollup merge of #134366 - harrisonkaiser:no-break-space, r=davidtwco

2024-12-20T13:46:59+00:00

Fix logical error with what text is considered whitespace. There appears to be a logical issue around what counts as leading white-space. There is code which does a subtraction assuming that no errors will be reported inside the leading whitespace. However we compute the length of that whitespace with std::char::is_whitespace and not rustc_lexer::is_whitespace. The former will include a no-break space while later will excluded it. We can only safely make the assumption that no errors will be reported in whitespace if it is all "Rust Standard" whitespace. Indeed an error does occur in unicode whitespace if it contains a no-break space. In that case the subtraction will cause a ICE (for a compiler in debug mode) as described in https://github.com/rust-lang/rust/issues/132918.

chore: fix some typos

2024-12-18T15:23:44+00:00

Signed-off-by: acceptacross

Auto merge of #134243 - nnethercote:re-export-more-rustc_span, r=jieyouxu

2024-12-18T02:56:38+00:00

Re-export more `rustc_span::symbol` things from `rustc_span`. `rustc_span::symbol` defines some things that are re-exported from `rustc_span`, such as `Symbol` and `sym`. But it doesn't re-export some closely related things such as `Ident` and `kw`. So you can do `use rustc_span::{Symbol, sym}` but you have to do `use rustc_span::symbol::{Ident, kw}`, which is inconsistent for no good reason. This commit re-exports `Ident`, `kw`, and `MacroRulesNormalizedIdent`, and changes many `rustc_span::symbol::` qualifiers to `rustc_span::`. This is a 300+ net line of code reduction, mostly because many files with two `use rustc_span` items can be reduced to one. r? `@jieyouxu`

Re-export more `rustc_span::symbol` things from `rustc_span`.

2024-12-18T02:38:53+00:00

`rustc_span::symbol` defines some things that are re-exported from `rustc_span`, such as `Symbol` and `sym`. But it doesn't re-export some closely related things such as `Ident` and `kw`. So you can do `use rustc_span::{Symbol, sym}` but you have to do `use rustc_span::symbol::{Ident, kw}`, which is inconsistent for no good reason. This commit re-exports `Ident`, `kw`, and `MacroRulesNormalizedIdent`, and changes many `rustc_span::symbol::` qualifiers in `compiler/` to `rustc_span::`. This is a 200+ net line of code reduction, mostly because many files with two `use rustc_span` items can be reduced to one.

Fix logical error with what text is considered whitespace.

2024-12-17T04:34:46+00:00

There is a logical issue around what counts as leading white-space. There is code which does a subtraction assuming that no errors will be reported inside the leading whitespace. However we compute the length of that whitespace with std::char::is_whitespace and not rustc_lexer::is_whitespace. The former will include a no-break space while later will excluded it. We can only safely make the assumption that no errors will be reported in whitespace if it is all "Rust Standard" whitespace. Indeed an error does occur in unicode whitespace if it contains a no-break space.

update uses of extract_if in the compiler

2024-12-16T21:06:52+00:00

Rollup merge of #134181 - estebank:trim-render, r=oli-obk

2024-12-14T02:54:31+00:00

Tweak multispan rendering to reduce output length Consider comments and bare delimiters the same as an "empty line" for purposes of hiding rendered code output of long multispans. This results in more aggressive shortening of rendered output without losing too much context, specially in `*.stderr` tests that have "hidden" comments. We do that check not only on the first 4 lines of the multispan, but now also on the previous to last line as well.

Account for `///` when rendering multiline spans

2024-12-13T18:48:33+00:00

Don't consider `///` and `//!` docstrings to be empty for the purposes of multiline span rendering.