https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.89.0 2025-04-20T21:35:56+00:00 2025-04-20T21:35:56+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-16T06:13:50+00:00 urn:sha1:bf8ce32558a4657d077a6761eaa293d0645c2e16 By replacing them with `{Open,Close}{Param,Brace,Bracket,Invisible}`. PR #137902 made `ast::TokenKind` more like `lexer::TokenKind` by replacing the compound `BinOp{,Eq}(BinOpToken)` variants with fieldless variants `Plus`, `Minus`, `Star`, etc. This commit does a similar thing with delimiters. It also makes `ast::TokenKind` more similar to `parser::TokenType`. This requires a few new methods: - `TokenKind::is_{,open_,close_}delim()` replace various kinds of pattern matches. - `Delimiter::as_{open,close}_token_kind` are used to convert `Delimiter` values to `TokenKind`. Despite these additions, it's a net reduction in lines of code. This is because e.g. `token::OpenParen` is so much shorter than `token::OpenDelim(Delimiter::Parenthesis)` that many multi-line forms reduce to single line forms. And many places where the number of lines doesn't change are still easier to read, just because the names are shorter, e.g.: ``` - } else if self.token != token::CloseDelim(Delimiter::Brace) { + } else if self.token != token::CloseBrace { ``` 2025-04-02T05:16:49+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-05-15T23:22:37+00:00 urn:sha1:4d8f7577b5f2f7c72d1e258c07b882d0afcf0956 2024-12-18T02:38:53+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-12-12T23:29:23+00:00 urn:sha1:2620eb42d72d24baa1ca1056a769862b92c85f7f `rustc_span::symbol` defines some things that are re-exported from `rustc_span`, such as `Symbol` and `sym`. But it doesn't re-export some closely related things such as `Ident` and `kw`. So you can do `use rustc_span::{Symbol, sym}` but you have to do `use rustc_span::symbol::{Ident, kw}`, which is inconsistent for no good reason. This commit re-exports `Ident`, `kw`, and `MacroRulesNormalizedIdent`, and changes many `rustc_span::symbol::` qualifiers in `compiler/` to `rustc_span::`. This is a 200+ net line of code reduction, mostly because many files with two `use rustc_span` items can be reduced to one. 2024-10-30T05:40:36+00:00 Matthias Krüger matthias.krueger@famsik.de 2024-10-30T05:40:36+00:00 urn:sha1:2480e3bbc5c74717dbc9475edef58d492e443deb Use `token_descr` more in error messages This is the first two commits from #124141, put into their own PR to get things rolling. Commit messages have the details. r? ``@estebank`` cc ``@petrochenkov`` 2024-10-28T15:05:08+00:00 klensy klensy@users.noreply.github.com 2024-10-07T19:22:51+00:00 urn:sha1:746b675c5aabc7a61443f16a37223720657544d2 2024-10-28T03:20:28+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-06-25T02:52:15+00:00 urn:sha1:dd2b027d5d509dd95c5ef6f83ea6283f3e98d5ed Much like the previous commit. I think the removal of "the token" in each message is fine here. There are many more error messages that mention tokens without saying "the token" than those that do say it. 2024-09-22T23:11:29+00:00 Michael Goulet michael@errs.io 2024-09-22T23:05:04+00:00 urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1f 2024-09-06T14:32:48+00:00 Michael Goulet michael@errs.io 2024-09-05T09:43:55+00:00 urn:sha1:97910580aadab067ef13b5d0094a57e124c743ea 2024-08-27T02:40:38+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-08-27T02:40:38+00:00 urn:sha1:df5fbf05a15a391192c40680af968733524d99d0 Plus a tiny bit of reformatting. 2024-07-28T22:26:52+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-07-28T22:13:50+00:00 urn:sha1:84ac80f1921afc243d71fd0caaa4f2838c294102 The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options.