rust/compiler/rustc_expand/src/parse/tests.rs, branch 1.68.2

`rustc_expand`: remove `ref` patterns

2023-01-17T07:48:19+00:00

Split `MacArgs` in two.

2022-11-21T22:04:15+00:00

`MacArgs` is an enum with three variants: `Empty`, `Delimited`, and `Eq`. It's used in two ways: - For representing attribute macro arguments (e.g. in `AttrItem`), where all three variants are used. - For representing function-like macros (e.g. in `MacCall` and `MacroDef`), where only the `Delimited` variant is used. In other words, `MacArgs` is used in two quite different places due to them having partial overlap. I find this makes the code hard to read. It also leads to various unreachable code paths, and allows invalid values (such as accidentally using `MacArgs::Empty` in a `MacCall`). This commit splits `MacArgs` in two: - `DelimArgs` is a new struct just for the "delimited arguments" case. It is now used in `MacCall` and `MacroDef`. - `AttrArgs` is a renaming of the old `MacArgs` enum for the attribute macro case. Its `Delimited` variant now contains a `DelimArgs`. Various other related things are renamed as well. These changes make the code clearer, avoids several unreachable paths, and disallows the invalid values.

Remove `TreeAndSpacing`.

2022-07-29T05:52:15+00:00

A `TokenStream` contains a `Lrc>`. But this is not quite right. `Spacing` makes sense for `TokenTree::Token`, but does not make sense for `TokenTree::Delimited`, because a `TokenTree::Delimited` cannot be joined with another `TokenTree`. This commit fixes this problem, by adding `Spacing` to `TokenTree::Token`, changing `TokenStream` to contain a `Lrc>`, and removing the `TreeAndSpacing` typedef. The commit removes these two impls: - `impl From for TokenStream` - `impl From for TreeAndSpacing` These were useful, but also resulted in code with many `.into()` calls that was hard to read, particularly for anyone not highly familiar with the relevant types. This commit makes some other changes to compensate: - `TokenTree::token()` becomes `TokenTree::token_{alone,joint}()`. - `TokenStream::token_{alone,joint}()` are added. - `TokenStream::delimited` is added. This results in things like this: ```rust TokenTree::token(token::Semi, stmt.span).into() ``` changing to this: ```rust TokenStream::token_alone(token::Semi, stmt.span) ``` This makes the type of the result, and its spacing, clearer. These changes also simplifies `Cursor` and `CursorRef`, because they no longer need to distinguish between `next` and `next_with_spacing`.

use `CursorRef` more, to not to clone `Tree`s

2022-05-18T15:43:48+00:00

rustc_ast: Harmonize delimiter naming with `proc_macro::Delimiter`

2022-04-28T07:04:29+00:00

re-format with new rustfmt

2021-11-30T18:08:41+00:00

Rework SESSION_GLOBALS API to prevent overwriting it

2021-07-08T14:16:28+00:00

Use the now available implementation of `IntoIterator` for arrays

2021-06-14T21:40:09+00:00

ast: Keep expansion status for out-of-line module items

2021-02-18T10:07:49+00:00

Also remove `ast::Mod` which is mostly redundant now

Force token collection to run when parsing nonterminals

2021-01-20T23:09:32+00:00

Fixes #81007 Previously, we would fail to collect tokens in the proper place when only builtin attributes were present. As a result, we would end up with attribute tokens in the collected `TokenStream`, leading to duplication when we attempted to prepend the attributes from the AST node. We now explicitly track when token collection must be performed due to nomterminal parsing.