rust/compiler/rustc_graphviz, branch perf-tmp

Remove `#![warn(unreachable_pub)]` from all `compiler/` crates.

2025-03-11T02:14:21+00:00

It's no longer necessary now that `-Wunreachable_pub` is being passed.

Revert "Use workspace lints for crates in `compiler/` #138084"

2025-03-10T10:12:47+00:00

Revert to buy time to consider options that avoids breaking downstream usages of cargo on distributed `rustc-src` artifacts, where such cargo invocations fail due to inability to inherit `lints` from workspace root manifest's `workspace.lints` (this is only valid for the source rust-lang/rust workspace, but not really the distributed `rustc-src` artifacts). This breakage was reported in . This reverts commit 48caf81484b50dca5a5cebb614899a3df81ca898, reversing changes made to c6662879b27f5161e95f39395e3c9513a7b97028.

Remove `#![warn(unreachable_pub)]` from all `compiler/` crates.

2025-03-07T21:41:43+00:00

(Except for `rustc_codegen_cranelift`.) It's no longer necessary now that `unreachable_pub` is in the workspace lints.

Specify rust lints for `compiler/` crates via Cargo.

2025-03-07T21:41:09+00:00

By naming them in `[workspace.lints.rust]` in the top-level `Cargo.toml`, and then making all `compiler/` crates inherit them with `[lints] workspace = true`. (I omitted `rustc_codegen_{cranelift,gcc}`, because they're a bit different.) The advantages of this over the current approach: - It uses a standard Cargo feature, rather than special handling in bootstrap. So, easier to understand, and less likely to get accidentally broken in the future. - It works for proc macro crates. It's a shame it doesn't work for rustc-specific lints, as the comments explain.

Upgrade the compiler to edition 2024

2025-02-22T00:01:48+00:00

Rustfmt

2025-02-08T22:12:13+00:00

Reformat using the new identifier sorting from rustfmt

2024-09-22T23:11:29+00:00

Add `warn(unreachable_pub)` to `rustc_graphviz`.

2024-08-27T02:58:29+00:00

Reformat `use` declarations.

2024-07-28T22:26:52+00:00

The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options.

Use `tidy` to sort crate attributes for all compiler crates.

2024-06-12T05:49:10+00:00

We already do this for a number of crates, e.g. `rustc_middle`, `rustc_span`, `rustc_metadata`, `rustc_span`, `rustc_errors`. For the ones we don't, in many cases the attributes are a mess. - There is no consistency about order of attribute kinds (e.g. `allow`/`deny`/`feature`). - Within attribute kind groups (e.g. the `feature` attributes), sometimes the order is alphabetical, and sometimes there is no particular order. - Sometimes the attributes of a particular kind aren't even grouped all together, e.g. there might be a `feature`, then an `allow`, then another `feature`. This commit extends the existing sorting to all compiler crates, increasing consistency. If any new attribute line is added there is now only one place it can go -- no need for arbitrary decisions. Exceptions: - `rustc_log`, `rustc_next_trait_solver` and `rustc_type_ir_macros`, because they have no crate attributes. - `rustc_codegen_gcc`, because it's quasi-external to rustc (e.g. it's ignored in `rustfmt.toml`).