rust/compiler/rustc_hir_analysis/src/collect, branch masterhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=master2025-10-02T08:09:33+00:00Auto merge of #147138 - jackh726:split-canonical-bound, r=lcnr2025-10-02T08:09:33+00:00borsbors@rust-lang.org2025-10-02T08:09:33+00:00urn:sha1:4b9c62b4da3e17cee99d3d2052f1c576b188e2a8
Split Bound index into Canonical and Bound
See [#t-types/trait-system-refactor > perf `async-closures/post-mono-higher-ranked-hang.rs`](https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/perf.20.60async-closures.2Fpost-mono-higher-ranked-hang.2Ers.60/with/541535613) for context
Things compile and tests pass, but not sure if this actually solves the perf issue (edit: it does). Opening up this to do a perf (and maybe crater) run.
r? lcnr
Rollup merge of #146593 - Jules-Bertholet:restrict-e0719, r=BoxyUwU2025-10-01T16:42:34+00:00Matthias Krüger476013+matthiaskrgr@users.noreply.github.com2025-10-01T16:42:34+00:00urn:sha1:15b7792a65a5f50d22f77c02cff75f8015c48bc8
Allow specifying multiple bounds for same associated item, except in trait objects
Supersedes https://github.com/rust-lang/rust/pull/143146, fixes https://github.com/rust-lang/rust/issues/143143.
This PR proposes to stop enforcing E0719 in all contexts other than trait object types.
E0719 forbids constraining the same associated item twice within the same angle-bracket delimited associated item bound list (the `…` inside `T: Trait<…>`). For example, the following are forbidden:
| Forbidden | Working alternative |
|--------------------------------------------|--------------------------------------------------------------------|
| `T: Trait<Gat<u32> = u32, Gat<u64> = u64>` | `T: Trait<Gat<u32> = u32> + Trait<Gat<u64> = u64>` |
| `T: Iterator<Item = u32, Item = i32>` | `T: Iterator<Item = u32> + Iterator<Item = i32>` (trivially false) |
| `T: Iterator<Item = u32, Item = u32>` | `T: Iterator<Item = u32>` |
| `T: Iterator<Item: Send, Item: Sync>` | `T: Iterator<Item: Send + Sync>` |
| `T: Trait<ASSOC = 3, ASSOC = 4>` | `T: Trait<ASSOC = 3> + Trait<ASSOC = 4>` (trivially false) |
| `T: Trait<ASSOC = 3, ASSOC = 3>` | `T: Trait<ASSOC = 3>` |
With this PR, all those previously forbidden examples would start working, as well as their APIT and RPIT equivalents.
Types like `dyn Iterator<Item = u32, Item = u32>` will continue to be rejected, however. See https://github.com/rust-lang/rust/pull/143146#issuecomment-3274421752 for the reason why.
```@rustbot``` label T-lang T-types needs-fcp
Split Bound into Canonical and Bound2025-09-30T16:58:28+00:00jackh726git@jackhuey.me2025-09-28T23:04:55+00:00urn:sha1:d1bbd39c59523d7a5499816a9da200a5910f8b7fAdd `overlapping_assoc_constraints` param to `lower_bounds`2025-09-29T14:34:19+00:00Jules Bertholetjulesbertholet@quoi.xyz2025-09-29T14:34:19+00:00urn:sha1:9f667cdd243d905848ccfc031f4c1373828c9a7dRename various "concrete opaque type" terminology to say "hidden type"2025-09-27T21:58:02+00:00Boxy Uwurust@boxyuwu.dev2025-09-27T21:58:02+00:00urn:sha1:4d411775139e1bc39c2752d78e40f2bcecb5304bRemove `DynKind`2025-09-17T02:46:46+00:00León Orell Valerian Liehrme@fmease.dev2025-09-17T02:16:47+00:00urn:sha1:26f3337d4eda0ba22b615744fda0185d0ee344b1Introduce hir::ImplItemImplKind2025-09-12T20:14:15+00:00Cameron Steffencam.steffen94@gmail.com2025-08-05T20:59:44+00:00urn:sha1:88a8bfcaf0398011b621a981483c288d1e3b64e2Introduce trait_item_of2025-09-12T20:10:30+00:00Cameron Steffencam.steffen94@gmail.com2025-08-15T21:12:35+00:00urn:sha1:16c218c57ff83c82ba58753c3a67f697e260adc1Default auto traits: revert to the default supertraits2025-09-10T12:08:06+00:00Bryanskiyivakin.kir@gmail.com2025-08-19T18:34:33+00:00urn:sha1:bd089e1e6e52256c0535f19f58b4b6fe9609b70cRemove dead code stemming from an old effects desugaring2025-09-01T19:39:01+00:00León Orell Valerian Liehrme@fmease.dev2025-09-01T19:39:01+00:00urn:sha1:6fc0cf428885a4939fc3b6f60f638ce09e48339f