rust/compiler/rustc_hir_analysis/src/structured_errors, branch 1.69.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.69.02023-02-23T17:27:06+00:00diagnostics: remove inconsistent English article "this" from E01072023-02-23T17:27:06+00:00Michael Howellmichael@notriddle.com2023-02-23T17:27:06+00:00urn:sha1:a5b639dc012e735bd6888a1e513bd925a7e101ba
Consider `tests/ui/const-generics/generic_const_exprs/issue-102768.stderr`,
the error message where it gives additional notes about where the associated
type is defined, and how the dead code lint doesn't have an article,
like in `tests/ui/lint/dead-code/issue-85255.stderr`. They don't have
articles, so it seems unnecessary to have one here.
Auto merge of #108324 - notriddle:notriddle/assoc-fn-method, r=compiler-errors,davidtwco,estebank,oli-obk2023-02-23T00:19:12+00:00borsbors@rust-lang.org2023-02-23T00:19:12+00:00urn:sha1:0978711950b77582e4f8f334f6e9848d48ab7790
diagnostics: if AssocFn has self argument, describe as method
Discussed in https://rust-lang.zulipchat.com/#narrow/stream/147480-t-compiler.2Fwg-diagnostics/topic/.22associated.20function.22.20vs.20.22method.22/near/329265515
This commit also changes the tooltips on rustdoc intra-doc links targeting methods.
For anyone not sure why this is being done, see the Reference definitions of these terms in <https://doc.rust-lang.org/1.67.1/reference/items/associated-items.html#methods>
> Associated functions whose first parameter is named `self` are called methods and may be invoked using the [method call operator](https://doc.rust-lang.org/1.67.1/reference/expressions/method-call-expr.html), for example, `x.foo()`, as well as the usual function call notation.
In particular, while this means it's technically correct for rustc to refer to a method as an associated function (and there are a few cases where it'll still do so), rustc *must never* use the term "method" to refer to an associated function that does not have a `self` parameter.
Remove type-traversal trait aliases2023-02-22T17:04:58+00:00Alan Egertoneggyal@gmail.com2023-02-22T02:18:40+00:00urn:sha1:695072daa6cc04045f2aa79d751d884ad5263080diagnostics: if AssocFn has self argument, describe as method2023-02-22T15:40:33+00:00Michael Howellmichael@notriddle.com2023-02-21T21:05:32+00:00urn:sha1:3d056c31257cc26760b7e65c5dfdae069f7ddc74
Discussed in
https://rust-lang.zulipchat.com/#narrow/stream/147480-t-compiler.2Fwg-diagnostics/topic/.22associated.20function.22.20vs.20.22method.22/near/329265515
This commit also changes the tooltips on rustdoc intra-doc links
targeting methods.
Copy `ty::AssocItem` all other the place2023-02-15T20:22:41+00:00Maybe Wafflewaffle.lapkin@gmail.com2023-02-06T08:57:34+00:00urn:sha1:a32d39274113c30d8e367f729028e605ccbc6313`rustc_hir_analysis`: remove `ref` patterns2023-01-17T07:48:19+00:00Maybe Wafflewaffle.lapkin@gmail.com2023-01-09T16:30:40+00:00urn:sha1:09485eaae12b2f268d8e0c90671d759138d82778use smaller spans for missing lifetime/generic args2023-01-06T12:55:23+00:00Takayuki Maedatakoyaki0316@gmail.com2023-01-06T11:55:10+00:00urn:sha1:804dea9ca6a02baedb1efc639b848fa080dbf51d
fix rustdoc ui test
rename find_parent_node to opt_parent_id2023-01-04T00:43:13+00:00Michael Gouletmichael@errs.io2023-01-03T07:31:33+00:00urn:sha1:6af339dbfac612c13ae3811b70a066f6babc5e02Change how suggested lifetime args are computed.2022-11-24T17:48:42+00:00Camille GILLOTgillot.camille@gmail.com2022-11-06T09:45:34+00:00urn:sha1:41090346d844b625ac58004066184d34a9d24f99Fix substraction with overflow in `wrong_number_of_generic_args.rs`2022-11-19T17:53:36+00:00Mahmoud Mazouzmazouz.mahmoud@outlook.com2022-11-19T17:53:36+00:00urn:sha1:01f2a1542006631d6644ac767926e3bd3324f3c0
Rarranging the substration and equality check into an addition and an equality
check is sufficient.
Algebra is cool, isn't it?
Co-authored-by: Michael Goulet <michael@errs.io>