rust/compiler/rustc_hir_analysis/src/structured_errors, branch 1.76.0

Move some methods from `tcx.hir()` to `tcx`

2023-12-12T14:40:29+00:00

Renamings: - find -> opt_hir_node - get -> hir_node - find_by_def_id -> opt_hir_node_by_def_id - get_by_def_id -> hir_node_by_def_id Fix rebase changes using removed methods Use `tcx.hir_node_by_def_id()` whenever possible in compiler Fix clippy errors Fix compiler Apply suggestions from code review Co-authored-by: Vadim Petrochenkov Add FIXME for `tcx.hir()` returned type about its removal Simplify with with `tcx.hir_node_by_def_id`

Rollup merge of #116553 - gurry:116464-assoc-type-invalid-suggestion, r=compiler-errors

2023-10-25T21:37:09+00:00

Do not suggest 'Trait' when in trait impl Fixes #116464 We now skip the suggestion if we're in an impl of the trait.

Do not suggest 'Trait' when in trait impl

2023-10-25T03:41:16+00:00

because that would be illegal syntax

Format all the let chains in compiler

2023-10-13T08:59:36+00:00

lower impl const to bind to host effect param

2023-08-06T13:34:53+00:00

inline format!() args from rustc_codegen_llvm to the end (4)

2023-07-25T21:20:28+00:00

r? @WaffleLapkin

Re-format let-else per rustfmt update

2023-07-13T01:49:27+00:00

Use `Option::is_some_and` and `Result::is_ok_and` in the compiler

2023-05-24T14:20:41+00:00

Restrict `From` for `{D,Subd}iagnosticMessage`.

2023-05-02T22:44:39+00:00
Currently a `{D,Subd}iagnosticMessage` can be created from any type that impls `Into`. That includes `&str`, `String`, and `Cow<'static, str>`, which are reasonable. It also includes `&String`, which is pretty weird, and results in many places making unnecessary allocations for patterns like this: ``` self.fatal(&format!(...)) ``` This creates a string with `format!`, takes a reference, passes the reference to `fatal`, which does an `into()`, which clones the reference, doing a second allocation. Two allocations for a single string, bleh. This commit changes the `From` impls so that you can only create a `{D,Subd}iagnosticMessage` from `&str`, `String`, or `Cow<'static, str>`. This requires changing all the places that currently create one from a `&String`. Most of these are of the `&format!(...)` form described above; each one removes an unnecessary static `&`, plus an allocation when executed. There are also a few places where the existing use of `&String` was more reasonable; these now just use `clone()` at the call site. As well as making the code nicer and more efficient, this is a step towards possibly using `Cow<'static, str>` in `{D,Subd}iagnosticMessage::{Str,Eager}`. That would require changing the `From<&'a str>` impls to `From<&'static str>`, which is doable, but I'm not yet sure if it's worthwhile.

Add `(..)` syntax for RTN

2023-03-28T01:14:28+00:00