https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=stable 2025-05-07T12:39:54+00:00 2025-05-07T12:39:54+00:00 bors bors@rust-lang.org 2025-05-07T12:39:54+00:00 urn:sha1:3ef8e64ce9f72ee8d600d55bc43b36eed069b252 Use thread local dep graph encoding This adds thread local encoding of dep graph nodes. Each thread has a `MemEncoder` that gets flushed to the global `FileEncoder` when it exceeds 64 kB. Each thread also has a local cache of dep indices. This means there can now be empty gaps in `SerializedDepGraph`. Indices are marked green and also allocated by the new atomic operation `DepNodeColorMap::try_mark_green` as the encoder lock is removed. 2025-05-06T04:35:06+00:00 Zalathar Zalathar@users.noreply.github.com 2025-05-06T02:54:03+00:00 urn:sha1:9e7fb67838ce06e418d078c4d04b0ff578bd1f43 2025-05-01T08:20:31+00:00 John Kåre Alsaker john.kare.alsaker@gmail.com 2025-04-11T19:27:53+00:00 urn:sha1:d3ec14bbec7d3647a3c1a3bfdf2cafb0f72bf937 2025-04-16T23:50:52+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-10T04:33:59+00:00 urn:sha1:2fef0a30ae6b2687dfb286cb544d2a542f7e2335 I'm removing empty identifiers everywhere, because in practice they always mean "no identifier" rather than "empty identifier". (An empty identifier is impossible.) It's better to use `Option` to mean "no identifier" because you then can't forget about the "no identifier" possibility. Some specifics: - When testing an attribute for a single name, the commit uses the `has_name` method. - When testing an attribute for multiple names, the commit uses the new `has_any_name` method. - When using `match` on an attribute, the match arms now have `Some` on them. In the tests, we now avoid printing empty identifiers by not printing the identifier in the `error:` line at all, instead letting the carets point out the problem. 2025-04-14T18:47:15+00:00 Chris Denton chris@chrisdenton.dev 2025-04-14T18:35:51+00:00 urn:sha1:1d757833c6aa126e468275c1cd7285dee53a1de6 2025-04-02T05:25:27+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-02T05:25:27+00:00 urn:sha1:1830245a224c523f86ad3c62be76be3f336a9fb0 These are no longer needed now that `Nonterminal` is gone. 2025-03-24T15:02:09+00:00 bors bors@rust-lang.org 2025-03-24T15:02:09+00:00 urn:sha1:4510e86a41388733675465a8647d4235f3bf2023 Only use the new node hashmap for anonymous nodes This is a rebase of https://github.com/rust-lang/rust/pull/112469. cc `@cjgillot` 2025-03-21T21:03:49+00:00 bors bors@rust-lang.org 2025-03-21T21:03:49+00:00 urn:sha1:48b36c9d5943a4aef49aa04b8059b92d65ff31a9 Avoid no-op unlink+link dances in incr comp Incremental compilation scales quite poorly with the number of CGUs. This PR improves one reason for that. The incr comp process hard-links all the files from an old session into a new one, then it runs the backend, which may just hard-link the new session files into the output directory. Then codegen hard-links all the output files back to the new session directory. This PR (perhaps unimaginatively) fixes the silliness that ensues in the last step. The old `link_or_copy` implementation would be passed pairs of paths which are already the same inode, then it would blindly delete the destination and re-create the hard-link that it just deleted. This PR lets us skip both those operations. We don't skip the other two hard-links. `cargo +stage1 b && touch crates/core/main.rs && strace -cfw -elink,linkat,unlink,unlinkat cargo +stage1 b` before and then after on `ripgrep-13.0.0`: ``` % time seconds usecs/call calls errors syscall ------ ----------- ----------- --------- --------- ---------------- 52.56 0.024950 25 978 485 unlink 34.38 0.016318 22 727 linkat 13.06 0.006200 24 249 unlinkat ------ ----------- ----------- --------- --------- ---------------- 100.00 0.047467 24 1954 485 total ``` ``` % time seconds usecs/call calls errors syscall ------ ----------- ----------- --------- --------- ---------------- 42.83 0.014521 57 252 unlink 38.41 0.013021 26 486 linkat 18.77 0.006362 25 249 unlinkat ------ ----------- ----------- --------- --------- ---------------- 100.00 0.033904 34 987 total ``` This reduces the number of hard-links that are causing perf troubles, noted in https://github.com/rust-lang/rust/issues/64291 and https://github.com/rust-lang/rust/issues/137560 2025-03-19T19:12:37+00:00 John Kåre Alsaker john.kare.alsaker@gmail.com 2025-03-18T21:26:44+00:00 urn:sha1:68fd771bc1f186bfa7e825d8a87ac8f06a6efced 2025-03-19T19:12:37+00:00 Camille GILLOT gillot.camille@gmail.com 2023-03-12T10:56:20+00:00 urn:sha1:5a21f890e9b6aad452638a45e0ebce025da7334f