rust/compiler/rustc_interface/src/interface.rs, branch 1.72.0

Auto merge of #112708 - flip1995:clippy-freezing-pc-with-ice, r=oli-obk

2023-06-28T09:40:07+00:00

Avoid calling queries during query stack printing This has the side effect, that when Clippy should ICE (during an EarlyPass?) it will fill up the RAM with 2 GB/s and then freezes my Laptop. This is blocking the Clippy sync and might give some people really bad experiences, so this should be merged ASAP. r? `@cjgillot` cc `@Zoxc` I only commented this on [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60try_print_query_stack.60.20has.20.60ImplicitCtx.60.20during.20.60EarlyPass.60/near/363926180). I should've left a comment on the PR as well. My bad.

Provide more context for `rustc +nightly -Zunstable-options` on stable

2023-06-27T15:23:33+00:00

Avoid calling queries during query stack printing

2023-06-27T14:12:07+00:00

Avoid `Lrc>`.

2023-06-21T23:18:09+00:00

Because `Lrc>` is silly. (Clippy warns about `Rc>` and `Arc>`, and it would warn here if (a) we used Clippy with rustc, and (b) Clippy knew about `Lrc`.)

Collect VTable stats & add `-Zprint-vtable-sizes`

2023-06-12T15:58:35+00:00

Write to stdout if `-` is given as output file

2023-06-06T21:53:29+00:00

If `-o -` or `--emit KIND=-` is provided, output will be written to stdout instead. Binary output (`obj`, `llvm-bc`, `link` and `metadata`) being written this way will result in an error unless stdout is not a tty. Multiple output types going to stdout will trigger an error too, as they will all be mixded together.

Don't leak the function that is called on drop

2023-05-23T14:53:36+00:00

Avoid `&format("...")` calls in error message code.

2023-05-16T07:59:56+00:00

Error message all end up passing into a function as an `impl Into<{D,Subd}iagnosticMessage>`. If an error message is creatd as `&format("...")` that means we allocate a string (in the `format!` call), then take a reference, and then clone (allocating again) the reference to produce the `{D,Subd}iagnosticMessage`, which is silly. This commit removes the leading `&` from a lot of these cases. This means the original `String` is moved into the `{D,Subd}iagnosticMessage`, avoiding the double allocations. This requires changing some function argument types from `&str` to `String` (when all arguments are `String`) or `impl Into<{D,Subd}iagnosticMessage>` (when some arguments are `String` and some are `&str`).

Move expansion of query macros in rustc_middle to rustc_middle::query

2023-05-15T06:49:13+00:00

Auto merge of #108638 - Zoxc:erase-query-values-map, r=cjgillot

2023-05-14T13:47:01+00:00

Use dynamic dispatch for queries This replaces most concrete query values `V` with `MaybeUninit<[u8; { size_of::() }]>` reducing the code instantiated by queries. The compile time of `rustc_query_impl` is reduced by 27%. It is an alternative to https://github.com/rust-lang/rust/pull/107937 which uses unstable const generics while this uses a `EraseType` trait which maps query values to their erased variant. This is achieved by introducing an `Erased` type which does sanity check with `cfg(debug_assertions)`. The query caches gets instantiated with these erased types leaving the code in `rustc_query_system` unaware of them. `rustc_query_system` is changed to use instances of `QueryConfig` so that `rustc_query_impl` can pass in `DynamicConfig` which holds a pointer to a virtual table.

Benchmark	Before	After
Benchmark	Time	Time	%
🟣 clap:check	1.7055s	1.6949s	-0.62%
🟣 hyper:check	0.2547s	0.2528s	-0.73%
🟣 regex:check	0.9590s	0.9553s	-0.39%
🟣 syn:check	1.5457s	1.5440s	-0.11%
🟣 syntex_syntax:check	5.9092s	5.9009s	-0.14%
Total	10.3741s	10.3479s	-0.25%
Summary	1.0000s	0.9960s	-0.40%

Benchmark	Before	After
Benchmark	Time	Time	%
🟣 clap:check:initial	2.0605s	2.0575s	-0.15%
🟣 hyper:check:initial	0.3218s	0.3216s	-0.07%
🟣 regex:check:initial	1.1848s	1.1839s	-0.07%
🟣 syn:check:initial	1.9409s	1.9376s	-0.17%
🟣 syntex_syntax:check:initial	7.3105s	7.2928s	-0.24%
Total	12.8185s	12.7935s	-0.20%
Summary	1.0000s	0.9986s	-0.14%

Benchmark	Before	After
Benchmark	Time	Time	%
🟣 clap:check:unchanged	0.4606s	0.4617s	0.24%
🟣 hyper:check:unchanged	0.1335s	0.1336s	0.08%
🟣 regex:check:unchanged	0.3324s	0.3346s	0.65%
🟣 syn:check:unchanged	0.6268s	0.6307s	0.64%
🟣 syntex_syntax:check:unchanged	1.8248s	1.8508s	💔 1.43%
Total	3.3779s	3.4113s	0.99%
Summary	1.0000s	1.0061s	0.61%

It's based on https://github.com/rust-lang/rust/pull/108167. r? `@cjgillot`