rust/compiler/rustc_llvm/llvm-wrapper/SymbolWrapper.cpp, branch lcnr/rustc-dev-guidehttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=lcnr/rustc-dev-guide2024-11-04T05:35:39+00:00Trim and tidy includes in `rustc_llvm`2024-11-04T05:35:39+00:00ZalatharZalathar@users.noreply.github.com2024-11-03T10:09:01+00:00urn:sha1:920d2774ac92b102dedf07d04d5fd80214881699Update the minimum external LLVM to 182024-09-18T20:53:31+00:00Josh Stonejistone@redhat.com2024-09-17T19:37:45+00:00urn:sha1:6fd8a5068034ad8a60704ef72e335d1b4c32cfd4Fix null pointer dereference when a file is not an object file2024-08-14T19:37:14+00:00bjorn317426603+bjorn3@users.noreply.github.com2024-08-14T19:37:14+00:00urn:sha1:901c9daa05ec817c3a0f7aad87a928cfcfe00ce2Use toString instead of raw_svector_ostream for error messages2024-08-14T19:26:00+00:00bjorn317426603+bjorn3@users.noreply.github.com2024-08-14T19:21:44+00:00urn:sha1:7c972d75dca7d1ef0e5a7d356cdc4d61afcd739fFix review comments2024-07-07T17:08:55+00:00bjorn317426603+bjorn3@users.noreply.github.com2024-07-07T17:07:36+00:00urn:sha1:cd3f2f68c042e2957fff85ca89ba10cb0f2f12b3Fix building on LLVM 172024-07-07T17:08:42+00:00bjorn317426603+bjorn3@users.noreply.github.com2024-07-07T17:00:04+00:00urn:sha1:72223e205d91e4d689718a9f61b3f6c0346d19e8Sync ar_archive_writer to LLVM 18.1.32024-07-07T16:56:35+00:00bjorn317426603+bjorn3@users.noreply.github.com2024-04-16T18:31:43+00:00urn:sha1:58e551433d692579faf4ad59fb7f192aa9001677
From LLVM 15.0.0-rc3. This adds support for COFF archives containing
Arm64EC object files and has various fixes for AIX big archive files.
Format C++ files in `llvm-wrapper`2024-06-26T12:18:49+00:00DianQKdianqk@dianqk.net2024-06-04T14:46:20+00:00urn:sha1:e17c16d55b20b9d2702fafa017263406d1e94042Explicitly assign constructed C++ classes2024-03-06T05:15:56+00:00Jubilee Youngworkingjubilee@gmail.com2024-03-06T04:04:24+00:00urn:sha1:23623a08d6a181864a7b8609682eee27534b12f4
C++ style guides I am aware of recommend specifically preferring = syntax
for any classes with fairly obvious constructors[^0] that do not perform
any complicated logic in their constructor. I contend that all constructors
that the `rustc_llvm` code uses qualify. This has only become more common
since C++ 17 guaranteed many cases of copy initialization elision.
The other detail is that I tried to ask another contributor with
infinitely more C++ experience than me (i.e. any) what this constructor
syntax was, and they thought it was a macro. I know of no other language
that has adopted this same syntax. As the rustc codebase features many
contributors experienced in many other languages, using a less...
unique... style has many other benefits in making this code more
lucid and maintainable, which is something it direly needs.
[^0]: e.g. https://abseil.io/tips/88
suppress warnings on msvc2023-11-22T17:10:53+00:00Arlie Davisardavis@microsoft.com2023-11-22T17:10:53+00:00urn:sha1:6773fd1a9a9aae8da53596e15eb2098e0efbb9a2