rust/compiler/rustc_metadata/src/rmeta/decoder.rs, branch 1.83.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.83.02024-10-11T13:11:13+00:00Auto merge of #131045 - compiler-errors:remove-unnamed_fields, r=wesleywiser2024-10-11T13:11:13+00:00borsbors@rust-lang.org2024-10-11T13:11:13+00:00urn:sha1:f4966590d8edd5f493a1aab04016b94a75494329
Retire the `unnamed_fields` feature for now
`#![feature(unnamed_fields)]` was implemented in part in #115131 and #115367, however work on that feature has (afaict) stalled and in the mean time there have been some concerns raised (e.g.[^1][^2]) about whether `unnamed_fields` is worthwhile to have in the language, especially in its current desugaring. Because it represents a compiler implementation burden including a new kind of anonymous ADT and additional complication to field selection, and is quite prone to bugs today, I'm choosing to remove the feature.
However, since I'm not one to really write a bunch of words, I'm specifically *not* going to de-RFC this feature. This PR essentially *rolls back* the state of this feature to "RFC accepted but not yet implemented"; however if anyone wants to formally unapprove the RFC from the t-lang side, then please be my guest. I'm just not totally willing to summarize the various language-facing reasons for why this feature is or is not worthwhile, since I'm coming from the compiler side mostly.
Fixes #117942
Fixes #121161
Fixes #121263
Fixes #121299
Fixes #121722
Fixes #121799
Fixes #126969
Fixes #131041
Tracking:
* https://github.com/rust-lang/rust/issues/49804
[^1]: https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Unnamed.20struct.2Funion.20fields
[^2]: https://github.com/rust-lang/rust/issues/49804#issuecomment-1972619108
add unstable support for outputting file checksums for use in cargo2024-10-02T03:23:20+00:00Jacob Kieseljake@bitcrafters.co2024-06-22T07:27:59+00:00urn:sha1:bb5a8276be2d3dbc97d0f52e90db15455d542edfRemove unnamed field feature2024-10-01T17:55:46+00:00Michael Gouletmichael@errs.io2024-09-30T02:10:16+00:00urn:sha1:e3a0da18633a8cfb5263bb975747352690b01fcfImplement RFC3137 trim-paths sysroot changes2024-09-27T11:27:54+00:00Urgauurgau@numericable.fr2024-08-21T16:56:03+00:00urn:sha1:8075ddb98e594f75df45c0103838c61b4d6d747dReformat using the new identifier sorting from rustfmt2024-09-22T23:11:29+00:00Michael Gouletmichael@errs.io2024-09-22T23:05:04+00:00urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1fRollup merge of #129723 - compiler-errors:extern-providers, r=lcnr2024-08-31T08:08:56+00:00Matthias Krügermatthias.krueger@famsik.de2024-08-31T08:08:56+00:00urn:sha1:9510beba4d3709722952c1e92d756968a4b9e349
Simplify some extern providers
Simplifies some extern crate providers:
1. Generalize the `ProcessQueryValue` identity impl to work on non-`Option` types.
2. Allow `ProcessQueryValue` to wrap its output in an `EarlyBinder`, to simplify `explicit_item_bounds`/`explicit_item_super_predicates`.
3. Use `{ table }` and friends more when possible.
Simplify some extern providers2024-08-29T15:18:03+00:00Michael Gouletmichael@errs.io2024-08-29T03:22:40+00:00urn:sha1:8c798c89dc6ba2c19a46390c5a3756f0f675350eAdd `warn(unreachable_pub)` to `rustc_metadata`.2024-08-29T10:13:06+00:00Nicholas Nethercoten.nethercote@gmail.com2024-08-28T23:10:19+00:00urn:sha1:05e07381d07fc097be5922114adf4f40e0625d03Move 'tcx lifetime off of impl and onto methods2024-08-28T15:44:58+00:00Michael Gouletmichael@errs.io2024-08-28T14:58:35+00:00urn:sha1:19296ca23c08d2f272f1f0ccbafa94f6c00984c1Fix `elided_named_lifetimes` in code2024-08-24T16:21:32+00:00Pavel GrigorenkoGrigorenkoPV@ya.ru2024-08-22T22:12:57+00:00urn:sha1:53ce92770d0b1005cfc07cc8f14011339e2abc26