https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.77.2 2024-01-31T05:37:49+00:00 2024-01-31T05:37:49+00:00 bors bors@rust-lang.org 2024-01-31T05:37:49+00:00 urn:sha1:d53ddcd8bbb41cd977ab4f7a54886fd7779c0eba hir: Refactor getters for owner nodes 2024-01-30T12:00:52+00:00 Vadim Petrochenkov vadim.petrochenkov@gmail.com 2024-01-25T16:16:38+00:00 urn:sha1:64b6b5b6ce078684dea0d312e3ac0911e1d6a0df The query accept arbitrary DefIds, not just owner DefIds. The return can be an `Option` because if there are no nodes, then it doesn't matter whether it's due to NonOwner or Phantom. Also rename the query to `opt_hir_owner_nodes`. 2024-01-27T13:55:17+00:00 DaniPopes 57450786+DaniPopes@users.noreply.github.com 2024-01-27T13:55:15+00:00 urn:sha1:cda898b0d9a34e4a3615e879fcd4fb2da3fcead5 For consistency with normal functions. 2024-01-26T00:17:00+00:00 bors bors@rust-lang.org 2024-01-26T00:17:00+00:00 urn:sha1:dd2559e08e1530806740931037d6bb83ef956161 remove StructuralEq trait The documentation given for the trait is outdated: *all* function pointers implement `PartialEq` and `Eq` these days. So the `StructuralEq` trait doesn't really seem to have any reason to exist any more. One side-effect of this PR is that we allow matching on some consts that do not implement `Eq`. However, we already allowed matching on floats and consts containing floats, so this is not new, it is just allowed in more cases now. IMO it makes no sense at all to allow float matching but also sometimes require an `Eq` instance. If we want to require `Eq` we should adjust https://github.com/rust-lang/rust/pull/115893 to check for `Eq`, and rule out float matching for good. Fixes https://github.com/rust-lang/rust/issues/115881 2024-01-25T07:39:42+00:00 Matthias Krüger matthias.krueger@famsik.de 2024-01-25T07:39:42+00:00 urn:sha1:0c45e3c7ddccca2da8d140737f5e38eb76ff3289 Remove `track_errors` entirely follow up to https://github.com/rust-lang/rust/pull/119869 r? `@matthewjasper` There are some diagnostic changes adding new diagnostics or not emitting some anymore. We can improve upon that in follow-up work imo. 2024-01-24T06:56:23+00:00 Ralf Jung post@ralfj.de 2023-09-26T07:39:41+00:00 urn:sha1:0df7810734d396d1a3082eee674d542c81c269d2 2024-01-23T15:23:22+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2024-01-23T15:23:22+00:00 urn:sha1:db7cd5709133ef4a0e45bc13b1b3db7cbf1b3c8f 2024-01-22T14:35:46+00:00 Oli Scherer git-spam-no-reply9815368754983@oli-obk.de 2024-01-09T11:12:30+00:00 urn:sha1:f58af9ba28f1bb49f880da43227c65cc10673be2 2024-01-19T08:42:17+00:00 bors bors@rust-lang.org 2024-01-19T08:42:17+00:00 urn:sha1:92d727796be7c882d2efbc06e08bbf4743cf29dc Rollup of 9 pull requests Successful merges: - #119582 (bootstrap: handle vendored sources when remapping crate paths) - #119730 (docs: fix typos) - #119828 (Improved collapse_debuginfo attribute, added command-line flag) - #119869 (replace `track_errors` usages with bubbling up `ErrorGuaranteed`) - #120037 (Remove `next_root_ty_var`) - #120094 (tests/ui/asm/inline-syntax: adapt for LLVM 18) - #120096 (Set RUSTC_BOOTSTRAP=1 consistently) - #120101 (change `.unwrap()` to `?` on write where `fmt::Result` is returned) - #120102 (Fix typo in munmap_partial.rs) r? `@ghost` `@rustbot` modify labels: rollup 2024-01-19T02:36:13+00:00 bors bors@rust-lang.org 2024-01-19T02:36:13+00:00 urn:sha1:d3c9082a44f00b22152ebc9c92c129b10ccb7793 Get rid of the hir_owner query. This query was meant as a firewall between `hir_owner_nodes` which is supposed to change often, and the queries that only depend on the item signature. That firewall was inefficient, leaking the contents of the HIR body through `HirId`s. `hir_owner` incurs a significant cost, as we need to hash HIR twice in multiple modes. This PR proposes to remove it, and simplify the hashing scheme. For the future, `def_kind`, `def_span`... are much more efficient for incremental decoupling, and should be preferred.