rust/compiler/rustc_mir_dataflow/src/framework/engine.rs, branch 1.76.0

Deparameterize `Results` and `ResultsCursor`.

2023-11-26T23:35:43+00:00

They both now only ever contain a `Results<'tcx, A>`. This means `AnalysisResults` can be removed, as can many `borrow`/`borrow_mut` calls. Also `Results` no longer needs a `PhantomData` because `'tcx` is now named by `entry_sets`.

Remove `ResultsCloned` and `ResultsClonedCursor`.

2023-11-26T23:35:43+00:00

They're now unused.

Remove uses of `ResultsClonedCursor`.

2023-11-26T23:35:43+00:00

By just cloning the entire `Results` in the one place where `ResultsClonedCursor` was used. This is extra allocations but the performance effect is negligible.

Remove `ResultsRefCursor`.

2023-11-26T23:35:43+00:00

It's no longer used.

Remove another use of `as_results_cursor`.

2023-11-26T23:35:43+00:00

The new code is a little clunky, but I couldn't see how to make it better.

Remove `CloneAnalysis`.

2023-11-26T23:35:42+00:00

It's only implemented for analyses that implement `Copy`, which means it's basically a complicated synonym for `Copy`. So this commit removes it and uses `Copy` directly. (That direct use will be removed in a later commit.)

Remove some unused code relating to `ResultsCloned`.

2023-11-26T23:35:42+00:00

Use typedefs to clarify some impls.

2023-11-26T23:35:42+00:00

And insert some whitespace.

Use `'mir` lifetime name more.

2023-11-23T07:49:58+00:00

Some types have a `body: &'mir Body<'tcx>` and some have `body: &'a Body<'tcx>`. The former is more readable, so this commit converts some fo the latter to the former.

Remove unnecessary and misleading `..` in a pattern.

2023-11-23T04:29:26+00:00

All the fields are named.