https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=try 2025-06-29T12:39:13+00:00 2025-06-29T12:39:13+00:00 dianqk dianqk@dianqk.net 2025-06-16T14:31:25+00:00 urn:sha1:24e553e6bcfa329b04b93c0978e00b492224a255 2025-06-29T12:13:36+00:00 dianqk dianqk@dianqk.net 2025-06-08T07:30:18+00:00 urn:sha1:9f9cd5e2837f57504b92b5acbadb48ff0cb9e29c Avoid introducing a large number of changes when adding optional initialization fields. 2025-04-24T01:36:07+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-18T00:46:20+00:00 urn:sha1:92799b6f89d2d9bbfcb9b11d1bac57899d0bc435 `Results` contains and `Analysis` and an `EntryStates`. The unfortunate thing about this is that the analysis needs to be mutable everywhere (`&mut Analysis`) which forces the `Results` to be mutable everywhere, even though `EntryStates` is immutable everywhere. To fix this, this commit renames `Results` as `AnalysisAndResults`, renames `EntryStates` as `Results`, and separates the analysis and results as much as possible. (`AnalysisAndResults` doesn't get much use, it's mostly there to facilitate method chaining of `iterate_to_fixpoint`.) `Results` is immutable everywhere, which: - is a bit clearer on how the data is used, - avoids an unnecessary clone of entry states in `locals_live_across_suspend_points`, and - moves the results outside the `RefCell` in Formatter. The commit also reformulates `ResultsHandle` as the generic `CowMut`, which is simpler than `ResultsHandle` because it doesn't need the `'tcx` lifetime and the trait bounds. It also which sits nicely alongside the new use of `Cow` in `ResultsCursor`. 2025-02-08T22:12:13+00:00 bjorn3 17426603+bjorn3@users.noreply.github.com 2025-02-08T22:12:13+00:00 urn:sha1:1fcae03369abb4c2cc180cd5a49e1f4440a81300 2025-01-11T11:34:01+00:00 Rémy Rakic remy.rakic+github@gmail.com 2025-01-07T15:19:05+00:00 urn:sha1:a13354bea05968799a5be5521691322274fa6a9e This should make it clearer that this bitset is dense, with the advantages and disadvantages that it entails. 2024-12-10T01:09:25+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-11-26T07:15:18+00:00 urn:sha1:dddc09d2c359b57e43a0a6729e0d5e84894fbfe9 In most places, the `early` method is listed before the corresponding `primary` method, like you'd expect. This commit fixes two places where that isn't the case. 2024-12-10T01:07:13+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-11-26T04:31:02+00:00 urn:sha1:1d56943f34ee3e1d28ae7677b8410af867f267da The words "before" and "after" have an obvious temporal meaning, e.g. `seek_before_primary_effect`, `visit_statement_{before,after}_primary_effect`. But "before" is also used to name the effect that occurs before the primary effect of a statement/terminator; this is `Effect::Before`. This leads to the confusing possibility of talking about things happening "before/after the before event". This commit removes this awkward overloading of "before" by renaming `Effect::Before` as `Effect::Early`. It also renames some of the `Analysis` and `ResultsVisitor` methods to be more consistent. Here are the before and after names: - `Effect::{Before,Primary}` -> `Effect::{Early,Primary}` - `apply_before_statement_effect` -> `apply_early_statement_effect` - `apply_statement_effect` -> `apply_primary_statement_effect` - `visit_statement_before_primary_effect` -> `visit_after_early_statement_effect` - `visit_statement_after_primary_effect` -> `visit_after_primary_statement_effect` (And s/statement/terminator/ for all the terminator events.) 2024-12-10T01:04:45+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-11-26T03:21:17+00:00 urn:sha1:b059ea857cb39606c297378fefe6689d5723a4f6 "Set" doesn't make much sense here, we refer to domain values as "state" everywhere else. (This name confused me for a while.) 2024-10-14T05:35:47+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-10-10T01:06:25+00:00 urn:sha1:33abf6a0c8b9a051c06dcb43935f3e15c96ade45 To avoid some low-value boilerplate code. 2024-10-14T05:35:47+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-10-10T00:46:29+00:00 urn:sha1:ba13775319fa51933da6e90053a9f96778b15b6b With `GenKillAnalysis` gone, there is no need for them to be separate.