rust/compiler/rustc_mir_dataflow/src/framework, branch 1.76.0

remove redundant imports

2023-12-10T02:56:22+00:00

detects redundant imports that can be eliminated. for #117772 : In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.

Tweak `GenKillAnalysis`.

2023-12-07T22:49:11+00:00

`GenKillAnalysis` has five methods that take a transfer function arg: - `statement_effect` - `before_statement_effect` - `terminator_effect` - `before_terminator_effect` - `call_return_effect` All the transfer function args have type `&mut impl GenKill`, except for `terminator_effect`, which takes the simpler `Self::Domain`. But only the first two need to be `impl GenKill`. The other three can all be `Self::Domain`, just like `Analysis`. So this commit changes the last two to take `Self::Domain`, making `GenKillAnalysis` and `Analysis` more similar. (Another idea would be to make all these methods `impl GenKill`. But that doesn't work: `MaybeInitializedPlaces::terminator_effect` requires the arg be `Self::Domain` so that `self_is_unwind_dead(place, state)` can be called on it.)

Remove `impl_visitable!`.

2023-12-07T20:55:17+00:00

It is used just once. With it removed, the relevant code is a little boilerplate-y but much easier to read, and is the same length. Overall I think it's an improvement.

Remove unused arguments from `ResultsVisitor::visit_block_{start,end}`.

2023-12-07T20:55:17+00:00

Deparameterize `Results` and `ResultsCursor`.

2023-11-26T23:35:43+00:00

They both now only ever contain a `Results<'tcx, A>`. This means `AnalysisResults` can be removed, as can many `borrow`/`borrow_mut` calls. Also `Results` no longer needs a `PhantomData` because `'tcx` is now named by `entry_sets`.

Remove `ResultsCloned` and `ResultsClonedCursor`.

2023-11-26T23:35:43+00:00

They're now unused.

Remove uses of `ResultsClonedCursor`.

2023-11-26T23:35:43+00:00

By just cloning the entire `Results` in the one place where `ResultsClonedCursor` was used. This is extra allocations but the performance effect is negligible.

Remove `ResultsRefCursor`.

2023-11-26T23:35:43+00:00

It's no longer used.

Remove another use of `as_results_cursor`.

2023-11-26T23:35:43+00:00

The new code is a little clunky, but I couldn't see how to make it better.

Remove `CloneAnalysis`.

2023-11-26T23:35:42+00:00

It's only implemented for analyses that implement `Copy`, which means it's basically a complicated synonym for `Copy`. So this commit removes it and uses `Copy` directly. (That direct use will be removed in a later commit.)