https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=automation/bors/try 2025-08-20T22:04:00+00:00 2025-08-20T22:04:00+00:00 Josh Triplett josh@joshtriplett.org 2025-08-14T09:40:55+00:00 urn:sha1:bad4f5c13fa3c48cdc888c2f38bebf8c36440ccc `rustc_mir_dataflow` only uses `DefId`, which is a re-export from `rustc_span`. 2025-07-28T01:10:14+00:00 Kivooeo Kivooeo123@gmail.com 2025-07-26T01:21:54+00:00 urn:sha1:bae38bad7803be7fdf1878188da9650f82548016 2025-04-24T01:36:07+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-18T00:46:20+00:00 urn:sha1:92799b6f89d2d9bbfcb9b11d1bac57899d0bc435 `Results` contains and `Analysis` and an `EntryStates`. The unfortunate thing about this is that the analysis needs to be mutable everywhere (`&mut Analysis`) which forces the `Results` to be mutable everywhere, even though `EntryStates` is immutable everywhere. To fix this, this commit renames `Results` as `AnalysisAndResults`, renames `EntryStates` as `Results`, and separates the analysis and results as much as possible. (`AnalysisAndResults` doesn't get much use, it's mostly there to facilitate method chaining of `iterate_to_fixpoint`.) `Results` is immutable everywhere, which: - is a bit clearer on how the data is used, - avoids an unnecessary clone of entry states in `locals_live_across_suspend_points`, and - moves the results outside the `RefCell` in Formatter. The commit also reformulates `ResultsHandle` as the generic `CowMut`, which is simpler than `ResultsHandle` because it doesn't need the `'tcx` lifetime and the trait bounds. It also which sits nicely alongside the new use of `Cow` in `ResultsCursor`. 2024-12-18T02:38:53+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-12-12T23:29:23+00:00 urn:sha1:2620eb42d72d24baa1ca1056a769862b92c85f7f `rustc_span::symbol` defines some things that are re-exported from `rustc_span`, such as `Symbol` and `sym`. But it doesn't re-export some closely related things such as `Ident` and `kw`. So you can do `use rustc_span::{Symbol, sym}` but you have to do `use rustc_span::symbol::{Ident, kw}`, which is inconsistent for no good reason. This commit re-exports `Ident`, `kw`, and `MacroRulesNormalizedIdent`, and changes many `rustc_span::symbol::` qualifiers in `compiler/` to `rustc_span::`. This is a 200+ net line of code reduction, mostly because many files with two `use rustc_span` items can be reduced to one. 2024-12-10T01:02:50+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-11-26T03:17:12+00:00 urn:sha1:086233e282b2eb3bad0ab34e8953abc380e87ec6 Via the `Analysis::Domain` associated types, instead of the direct type name. 2024-11-22T06:02:04+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-11-22T03:39:29+00:00 urn:sha1:ae9ac0e383b8054ccded79ce26e48a14b485cb3c Its only use is in the `tests/ui/mir-dataflow/def_inits-1.rs` where it is tested via `rustc_peek_definite_init`. Also, it's probably buggy. It's supposed to be the inverse of `MaybeUninitializedPlaces`, and it mostly is, except that `apply_terminator_effect` is a little different, and `apply_switch_int_edge_effects` is missing. Unlike `MaybeUninitializedPlaces`, which is used extensively in borrow checking, any bugs in `DefinitelyInitializedPlaces` are easy to overlook because it is only used in one small test. This commit removes the analysis. It also removes `rustc_peek_definite_init`, `Dual` and `MeetSemiLattice`, all of which are no longer needed. 2024-10-29T22:41:46+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-10-29T21:45:46+00:00 urn:sha1:e54c177118a5150b819c8a84054504ab8e1e7748 This is a standard pattern: ``` MyAnalysis.into_engine(tcx, body).iterate_to_fixpoint() ``` `into_engine` and `iterate_to_fixpoint` are always called in pairs, but sometimes with a builder-style `pass_name` call between them. But a builder-style interface is overkill here. This has been bugging me a for a while. This commit: - Merges `Engine::new` and `Engine::iterate_to_fixpoint`. This removes the need for `Engine` to have fields, leaving it as a trivial type that the next commit will remove. - Renames `Analysis::into_engine` as `Analysis::iterate_to_fixpoint`, gives it an extra argument for the optional pass name, and makes it call `Engine::iterate_to_fixpoint` instead of `Engine::new`. This turns the pattern from above into this: ``` MyAnalysis.iterate_to_fixpoint(tcx, body, None) ``` which is shorter at every call site, and there's less plumbing required to support it. 2024-10-19T18:07:35+00:00 Michael Goulet michael@errs.io 2024-09-27T16:56:51+00:00 urn:sha1:e83e4e81123ea2babc04238d5aca01ec4bf3e763 2024-09-22T23:11:29+00:00 Michael Goulet michael@errs.io 2024-09-22T23:05:04+00:00 urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1f 2024-09-13T06:27:24+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-09-13T06:27:24+00:00 urn:sha1:bb943f93ff093d70012950f4617de8cfe74e5a36 Because that's what it is; no point having a different name for it.