https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.60.0 2022-02-03T22:16:03+00:00 2022-02-03T22:16:03+00:00 Matthias Krüger matthias.krueger@famsik.de 2022-02-03T22:12:25+00:00 urn:sha1:b80057d08d9f1b1726ec99dc57296cffec246bb1 useless_format map_flatten useless_conversion needless_bool filter_next clone_on_copy needless_option_as_deref 2021-12-27T19:07:05+00:00 Wesley Wiser wesleywiser@microsoft.com 2021-12-21T01:15:29+00:00 urn:sha1:ebc0d0d2a849ebf4cdca5f8cd4ce52d67a725bf6 2021-12-20T22:08:29+00:00 Wesley Wiser wesleywiser@microsoft.com 2021-12-20T21:36:56+00:00 urn:sha1:ef57f249a2244634a5c98d431d3bbfd715bd9c89 The issue here is that the logic used to determine which CGU to put the dead function stubs in doesn't handle cases where a module is never assigned to a CGU. The partitioning logic also caused issues in #85461 where inline functions were duplicated into multiple CGUs resulting in duplicate symbols. This commit fixes the issue by removing the complex logic used to assign dead code stubs to CGUs and replaces it with a much simplier model: we pick one CGU to hold all the dead code stubs. We pick a CGU which has exported items which increases the likelihood the linker won't throw away our dead functions and we pick the smallest to minimize the impact on compilation times for crates with very large CGUs. Fixes #86177 Fixes #85718 Fixes #79622 2021-12-15T06:32:14+00:00 Nicholas Nethercote n.nethercote@gmail.com 2021-12-15T03:39:23+00:00 urn:sha1:056d48a2c97860b2cce936f310331e606076fa01 2021-12-15T02:30:26+00:00 Nicholas Nethercote n.nethercote@gmail.com 2021-12-14T21:32:21+00:00 urn:sha1:8cddcd39ba2189da859a5164804556190906ee2a By changing `as_str()` to take `&self` instead of `self`, we can just return `&str`. We're still lying about lifetimes, but it's a smaller lie than before, where `SymbolStr` contained a (fake) `&'static str`! 2021-11-08T16:02:40+00:00 Michael Woerister michaelwoerister@posteo 2021-11-08T15:59:36+00:00 urn:sha1:fefe1e9192696c07f1655ed2726c4e114b70b096 2021-09-07T17:53:04+00:00 Camille GILLOT gillot.camille@gmail.com 2021-01-02T13:42:15+00:00 urn:sha1:81a600b6b7db07ebac28c8ddedd357e3c5b9951d