https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.78.0 2024-03-10T23:04:49+00:00 2024-03-10T23:04:49+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-03-06T03:00:16+00:00 urn:sha1:541d7cc65c56402f31335e41075838c0da5fbe01 To match `derive(Subdiagnostic)`. Also rename `add_to_diagnostic{,_with}` as `add_to_diag{,_with}`. 2024-03-10T22:15:09+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-03-06T00:02:56+00:00 urn:sha1:7a294e998b66ea6d410a6840cba80347fc4764c2 To match `derive(Diagnostic)`. Also rename `into_diagnostic` as `into_diag`. 2024-03-05T01:14:49+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-29T05:18:19+00:00 urn:sha1:573267cf3c10c13f4cb3b9935affd05925d938d0 2024-02-29T06:14:21+00:00 r0cky mu001999@outlook.com 2024-02-29T06:00:08+00:00 urn:sha1:1850ba7f548d13b7849bb8686728a113c0e6fb09 2024-02-27T21:55:35+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-22T23:20:45+00:00 urn:sha1:899cb40809a85eb9d89f6da3268713b83175360a Much better! Note that this involves renaming (and updating the value of) `DIAGNOSTIC_BUILDER` in clippy. 2024-02-22T02:47:30+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-22T01:36:01+00:00 urn:sha1:02423a5747f4b23cf1e4f51e5ec969887bf8be72 PR #119097 made the decision to make all `IntoDiagnostic` impls generic, because this allowed a bunch of nice cleanups. But four hand-written impls were unintentionally overlooked. This commit makes them generic. 2024-02-20T16:09:09+00:00 Michael Goulet michael@errs.io 2024-02-20T16:09:03+00:00 urn:sha1:9c8b107955194b80941ce825646bc2f34edc5dd5 2024-02-20T02:22:17+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-06T05:44:30+00:00 urn:sha1:f6f87798439e2ce7861da761b444fe0978335ed9 Currently many diagnostic modifier methods are available on both `Diagnostic` and `DiagnosticBuilder`. This commit removes most of them from `Diagnostic`. To minimize the diff size, it keeps them within `diagnostic.rs` but changes the surrounding `impl Diagnostic` block to `impl DiagnosticBuilder`. (I intend to move things around later, to give a more sensible code layout.) `Diagnostic` keeps a few methods that it still needs, like `sub`, `arg`, and `replace_args`. The `forward!` macro, which defined two additional methods per call (e.g. `note` and `with_note`), is replaced by the `with_fn!` macro, which defines one additional method per call (e.g. `with_note`). It's now also only used when necessary -- not all modifier methods currently need a `with_*` form. (New ones can be easily added as necessary.) All this also requires changing `trait AddToDiagnostic` so its methods take `DiagnosticBuilder` instead of `Diagnostic`, which leads to many mechanical changes. `SubdiagnosticMessageOp` gains a type parameter `G`. There are three subdiagnostics -- `DelayedAtWithoutNewline`, `DelayedAtWithNewline`, and `InvalidFlushedDelayedDiagnosticLevel` -- that are created within the diagnostics machinery and appended to external diagnostics. These are handled at the `Diagnostic` level, which means it's now hard to construct them via `derive(Diagnostic)`, so instead we construct them by hand. This has no effect on what they look like when printed. There are lots of new `allow` markers for `untranslatable_diagnostics` and `diagnostics_outside_of_impl`. This is because `#[rustc_lint_diagnostics]` annotations were present on the `Diagnostic` modifier methods, but missing from the `DiagnosticBuilder` modifier methods. They're now present. 2024-02-17T15:49:01+00:00 Urgau urgau@numericable.fr 2024-02-17T15:45:59+00:00 urn:sha1:d988d8f4ba069e11ace537feea4e4e226e7f4afe 2024-02-08T02:02:44+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-06T05:35:19+00:00 urn:sha1:6b175a848d72f0ea60d80de3bd74d0806a64c40f It avoids a lot of repetition.