rust/compiler/rustc_parse/src/errors.rs, branch 1.81.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.81.02024-07-19T08:48:03+00:00Rollup merge of #127350 - veera-sivarajan:bugfix-126311, r=lcnr2024-07-19T08:48:03+00:00Matthias Krügermatthias.krueger@famsik.de2024-07-19T08:48:03+00:00urn:sha1:c86e13f330b8689d21bc258f50e96d36196733b3
Parser: Suggest Placing the Return Type After Function Parameters
Fixes #126311
This PR suggests placing the return type after the function parameters when it's misplaced after a `where` clause.
This also tangentially improves diagnostics for cases like [this](https://github.com/veera-sivarajan/rust/blob/86d6f1312a77997ef994240e716288d61a343a6d/tests/ui/parser/issues/misplaced-return-type-without-where-issue-126311.rs#L1C1-L1C28) and adds doc comments for `parser::AllowPlus`.
Parser: Suggest Placing the Return Type After Function Parameters2024-07-18T21:56:34+00:00Veerasveera.2001@gmail.com2024-07-04T23:19:15+00:00urn:sha1:4cad705017f34a6545deb1505d0ce85537c18df5Fix ICE in suggestion caused by `⩵` being recovered as `==`2024-07-18T17:47:31+00:00Esteban Küberesteban@kuber.com.ar2024-07-16T22:43:30+00:00urn:sha1:67ec1326ee4e360b92dc6a6a3834bf8948532770
The second suggestion shown here would previously incorrectly assume that the span corresponding to `⩵` was 2 bytes wide composed by 2 1 byte wide chars, so a span pointing at `==` could point only at one of the `=` to remove it. Instead, we now replace the whole thing (as we should have the whole time):
```
error: unknown start of token: \u{2a75}
--> $DIR/unicode-double-equals-recovery.rs:1:16
|
LL | const A: usize ⩵ 2;
| ^
|
help: Unicode character '⩵' (Two Consecutive Equals Signs) looks like '==' (Double Equals Sign), but it is not
|
LL | const A: usize == 2;
| ~~
error: unexpected `==`
--> $DIR/unicode-double-equals-recovery.rs:1:16
|
LL | const A: usize ⩵ 2;
| ^
|
help: try using `=` instead
|
LL | const A: usize = 2;
| ~
```
Deny keyword lifetimes pre-expansion2024-07-16T16:06:25+00:00Michael Gouletmichael@errs.io2024-06-20T20:36:35+00:00urn:sha1:d0a1851ec2cf84bdb41bc4d788b3995a8463c543Make `;` suggestions inline2024-07-12T03:22:32+00:00Esteban Küberesteban@kuber.com.ar2024-07-12T03:22:32+00:00urn:sha1:71f16bdb32feb33762e5245efa37edac2bde724bMore accurate incorrect use of `await` suggestion2024-07-12T03:02:58+00:00Esteban Küberesteban@kuber.com.ar2024-07-11T22:07:11+00:00urn:sha1:377d14be88200d122f699aa989e4d1256f2173d2Use more accurate span for `:` to `::` suggestion2024-07-12T03:02:58+00:00Esteban Küberesteban@kuber.com.ar2024-07-11T22:03:08+00:00urn:sha1:b5f94c61f72cc85151dbd9bb1081fde2ab78f806Make `impl` and `!` removal suggestion `short`2024-07-12T03:02:57+00:00Esteban Küberesteban@kuber.com.ar2024-07-11T21:04:01+00:00urn:sha1:c2b3287483fb7fc1be7fdfbfd25044dd7a0320c0Make parse error suggestions verbose and fix spans2024-07-12T03:02:57+00:00Esteban Küberesteban@kuber.com.ar2024-07-06T03:07:46+00:00urn:sha1:692bc344d55cf9d86c60b06c92a70684d013c89f
Go over all structured parser suggestions and make them verbose style.
When suggesting to add or remove delimiters, turn them into multiple suggestion parts.
Add suggestions for possible missing `fn`, `struct`, or `enum` keywords2024-07-08T06:04:03+00:00trevyn230691+trevyn@users.noreply.github.com2024-07-06T10:14:53+00:00urn:sha1:b40adc9d3b56f230f295011ff78b0dfd378683ef