rust/compiler/rustc_parse/src/parser/attr_wrapper.rs, branch 1.65.0

Rename `{Create,Lazy}TokenStream` as `{To,Lazy}AttrTokenStream`.

2022-09-09T07:25:38+00:00

`To` is better than `Create` for indicating that this is a non-consuming conversion, rather than creating something out of nothing. And the addition of `Attr` is because the current names makes them sound like they relate to `TokenStream`, but really they relate to `AttrTokenStream`.

Rename `AttrAnnotatedToken{Stream,Tree}`.

2022-09-09T02:45:26+00:00

These two type names are long and have long matching prefixes. I find them hard to read, especially in combinations like `AttrAnnotatedTokenStream::new(vec![AttrAnnotatedTokenTree::Token(..)])`. This commit renames them as `AttrToken{Stream,Tree}`.

Move `Spacing` out of `AttrAnnotatedTokenStream`.

2022-09-09T02:00:46+00:00

And into `AttrAnnotatedTokenTree::Token`. PR #99887 did the same thing for `TokenStream`.

remove redundant clones

2022-09-03T05:58:41+00:00

Auto merge of #100869 - nnethercote:replace-ThinVec, r=spastorino

2022-09-01T08:01:06+00:00

Replace `rustc_data_structures::thin_vec::ThinVec` with `thin_vec::ThinVec` `rustc_data_structures::thin_vec::ThinVec` looks like this: ``` pub struct ThinVec(Option>>); ``` It's just a zero word if the vector is empty, but requires two allocations if it is non-empty. So it's only usable in cases where the vector is empty most of the time. This commit removes it in favour of `thin_vec::ThinVec`, which is also word-sized, but stores the length and capacity in the same allocation as the elements. It's good in a wider variety of situation, e.g. in enum variants where the vector is usually/always non-empty. The commit also: - Sorts some `Cargo.toml` dependency lists, to make additions easier. - Sorts some `use` item lists, to make additions easier. - Changes `clean_trait_ref_with_bindings` to take a `ThinVec` rather than a `&[TypeBinding]`, because this avoid some unnecessary allocations. r? `@spastorino`

Replace `rustc_data_structures::thin_vec::ThinVec` with `thin_vec::ThinVec`.

2022-08-29T05:42:13+00:00

`rustc_data_structures::thin_vec::ThinVec` looks like this: ``` pub struct ThinVec(Option>>); ``` It's just a zero word if the vector is empty, but requires two allocations if it is non-empty. So it's only usable in cases where the vector is empty most of the time. This commit removes it in favour of `thin_vec::ThinVec`, which is also word-sized, but stores the length and capacity in the same allocation as the elements. It's good in a wider variety of situation, e.g. in enum variants where the vector is usually/always non-empty. The commit also: - Sorts some `Cargo.toml` dependency lists, to make additions easier. - Sorts some `use` item lists, to make additions easier. - Changes `clean_trait_ref_with_bindings` to take a `ThinVec` rather than a `&[TypeBinding]`, because this avoid some unnecessary allocations.

Auto merge of #100497 - kadiwa4:remove_clone_into_iter, r=cjgillot

2022-08-28T18:31:08+00:00

Avoid cloning a collection only to iterate over it `@rustbot` label: +C-cleanup

Use `AttrVec` in more places.

2022-08-21T21:35:33+00:00

In some places we use `Vec` and some places we use `ThinVec` (a.k.a. `AttrVec`). This results in various points where we have to convert between `Vec` and `ThinVec`. This commit changes the places that use `Vec` to use `AttrVec`. A lot of this is mechanical and boring, but there are some interesting parts: - It adds a few new methods to `ThinVec`. - It implements `MapInPlace` for `ThinVec`, and introduces a macro to avoid the repetition of this trait for `Vec`, `SmallVec`, and `ThinVec`. Overall, it makes the code a little nicer, and has little effect on performance. But it is a precursor to removing `rustc_data_structures::thin_vec::ThinVec` and replacing it with `thin_vec::ThinVec`, which is implemented more efficiently.

avoid cloning and then iterating

2022-08-13T14:16:52+00:00

ast: Introduce some traits to get AST node properties generically

2022-05-11T09:43:27+00:00

And use them to avoid constructing some artificial `Nonterminal` tokens during expansion