rust/compiler/rustc_parse/src/parser/expr.rs, branch 1.63.0

Improve parsing errors and suggestions for bad if statements

2022-06-14T03:53:48+00:00

Rollup merge of #95211 - terrarier2111:improve-parser, r=compiler-errors

2022-06-13T22:47:22+00:00

Improve parser diagnostics This pr fixes https://github.com/rust-lang/rust/issues/93867 and contains a couple of diagnostics related changes to the parser. Here is a short list with some of the changes: - don't suggest the same thing that is the current token - suggest removing the current token if the following token is one of the suggestions (maybe incorrect) - tell the user to put a type or lifetime after where if there is none (as a warning) - reduce the amount of tokens suggested (via the new eat_noexpect and check_noexpect methods) If any of these changes are undesirable, i can remove them, thanks!

remove unnecessary `to_string` and `String::new`

2022-06-13T06:48:40+00:00

Improves parser diagnostics, fixes #93867

2022-06-12T15:48:52+00:00

Recover missing comma after match arm

2022-06-07T09:19:51+00:00

Add spaces before and after expr in add {} suggestion

2022-06-05T21:40:52+00:00

Co-authored-by: Michael Goulet

Suggest removing label in `'label: non_block_expr`

2022-06-05T19:34:11+00:00

Do not suggest adding labeled block if there are no labeled breaks

2022-06-05T19:12:51+00:00

Suggest adding `{}` for `'label: non_block_expr`

2022-06-05T12:45:29+00:00

Rollup merge of #97166 - nnethercote:move-conditions-out, r=estebank

2022-06-01T21:44:27+00:00

Move conditions out of recover/report functions. `Parser` has six recover/report functions that are passed a boolean, and nothing is done if the boolean has a particular value. This PR moves the tests outside the functions. This has the following effects. - The number of lines of code goes down. - Some `use` items become shorter. - Avoids the strangeness whereby 11 out of 12 calls to `maybe_recover_from_bad_qpath` pass `true` as the second argument. - Makes it clear at the call site that only one of `maybe_recover_from_bad_type_plus` and `maybe_report_ambiguous_plus` will be run. r? `@estebank`