rust/compiler/rustc_parse/src/parser/expr.rs, branch 1.67.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.67.02022-12-05T19:43:44+00:00Rollup merge of #105223 - lukas-code:(ExprWithBlock), r=petrochenkov2022-12-05T19:43:44+00:00Matthias Krügermatthias.krueger@famsik.de2022-12-05T19:43:44+00:00urn:sha1:66a4cb5368873fd793c53884e30dd543c4cad04c
suggest parenthesis around ExprWithBlock BinOp ExprWithBlock
fix https://github.com/rust-lang/rust/issues/105179
fix https://github.com/rust-lang/rust/issues/102171
more comments2022-12-03T22:54:06+00:00Lukas Markeffsky@2022-12-03T22:54:06+00:00urn:sha1:c808d0b289c1f8e0f26885bf44cb2ba1873ba10esuggest parenthesis around ExprWithBlock BinOp ExprWithBlock2022-12-03T19:02:39+00:00Lukas Markeffsky@2022-12-03T19:02:39+00:00urn:sha1:35c00a9731809292959e98b1e7da3c6e2673f3ccRollup merge of #104199 - SarthakSingh31:issue-97417-1, r=cjgillot2022-12-03T16:37:41+00:00Matthias Krügermatthias.krueger@famsik.de2022-12-03T16:37:41+00:00urn:sha1:c89bff29e562540c14497aa8cc8490e6a2cdeb73
Keep track of the start of the argument block of a closure
This removes a call to `tcx.sess.source_map()` from [compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs](https://github.com/rust-lang/rust/compare/master...SarthakSingh31:issue-97417-1?expand=1#diff-8406bbc0d0b43d84c91b1933305df896ecdba0d1f9269e6744f13d87a2ab268a) as required by #97417.
VsCode automatically applied `rustfmt` to the files I edited under `src/tools`. I can undo that if its a problem.
r? `@cjgillot`
Keep track of the start of the argument block of a closure2022-11-28T08:39:00+00:00Sarthak Singhss269@uw.edu2022-11-09T15:09:28+00:00urn:sha1:8f705e2425ff459566cd1da0f2c79060fdad9091Rename `ast::Lit` as `ast::MetaItemLit`.2022-11-28T04:18:49+00:00Nicholas Nethercoten.nethercote@gmail.com2022-11-23T04:39:42+00:00urn:sha1:e4a9150872a08db286208d07f5a6a90e466ca39cSuggest `.clone()` or `ref binding` on E03822022-11-23T20:17:47+00:00Esteban Küberesteban@kuber.com.ar2022-11-03T04:22:24+00:00urn:sha1:9e72e35ceb2af024e8ca6a74442269f7ec739173`rustc_parse`: remove `ref` patterns2022-11-22T18:49:16+00:00Maybe Wafflewaffle.lapkin@gmail.com2022-11-22T09:42:01+00:00urn:sha1:616df0f03ba343588ccc7894758f89825012d711Split `MacArgs` in two.2022-11-21T22:04:15+00:00Nicholas Nethercoten.nethercote@gmail.com2022-11-18T00:24:21+00:00urn:sha1:3e3a4192d8cda0c308ea87b2e8f6f1e8dcc74739
`MacArgs` is an enum with three variants: `Empty`, `Delimited`, and `Eq`. It's
used in two ways:
- For representing attribute macro arguments (e.g. in `AttrItem`), where all
three variants are used.
- For representing function-like macros (e.g. in `MacCall` and `MacroDef`),
where only the `Delimited` variant is used.
In other words, `MacArgs` is used in two quite different places due to them
having partial overlap. I find this makes the code hard to read. It also leads
to various unreachable code paths, and allows invalid values (such as
accidentally using `MacArgs::Empty` in a `MacCall`).
This commit splits `MacArgs` in two:
- `DelimArgs` is a new struct just for the "delimited arguments" case. It is
now used in `MacCall` and `MacroDef`.
- `AttrArgs` is a renaming of the old `MacArgs` enum for the attribute macro
case. Its `Delimited` variant now contains a `DelimArgs`.
Various other related things are renamed as well.
These changes make the code clearer, avoids several unreachable paths, and
disallows the invalid values.
Cleanup macro matching recovery2022-11-19T16:46:04+00:00Nilstrieb48135649+Nilstrieb@users.noreply.github.com2022-11-19T16:46:04+00:00urn:sha1:825b8db34ad908298fd8200a8fecfb7bdc146bdc
The retry has been implemented already.